first cut simple code completion results

pkg/analysis_server/lib/src/domain_completion.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library domain.completion;
 
+import 'dart:async';
+
 import 'package:analysis_server/src/analysis_server.dart';
 import 'package:analysis_server/src/constants.dart';
 import 'package:analysis_server/src/protocol.dart';
+import 'package:analysis_services/search/search_engine.dart';
+import 'package:analysis_server/src/collections.dart';
 
 /**
  * Instances of the class [CompletionDomainHandler] implement a [RequestHandler]
  * that handles requests in the search domain.
  */
 class CompletionDomainHandler implements RequestHandler {
   /**
    * The analysis server that is using this handler to process requests.
    */
   final AnalysisServer server;
 
   /**
+   * The [SearchEngine] for this server.
+   */
+  SearchEngine searchEngine;
+
+  /**
+   * The next searc response id.

[scheglov, 2014/07/17 20:40:00]

The comment has couple nits: "searc" is an incomplete word; and it is not a
search :-)

[danrubel, 2014/07/17 21:01:14]

Done.

+   */
+  int _nextCompletionId = 0;
+
+  /**
    * Initialize a newly created handler to handle requests for the given [server].
    */
   CompletionDomainHandler(this.server);
 
   @override
   Response handleRequest(Request request) {
     try {
       String requestName = request.method;
       if (requestName == COMPLETION_GET_SUGGESTIONS) {
         return getSuggestions(request);
       }
     } on RequestFailure catch (exception) {
       return exception.response;
     }
     return null;
   }
 
   Response getSuggestions(Request request) {
     // file
     RequestDatum fileDatum = request.getRequiredParameter(FILE);

[scheglov, 2014/07/17 20:40:00]

You could include these Datum objects here and later, they are pretty much
noise.

[danrubel, 2014/07/17 21:01:14]

Good point. Done.

     String file = fileDatum.asString();
     // offset
     RequestDatum offsetDatum = request.getRequiredParameter(OFFSET);
     int offset = offsetDatum.asInt();
-    // TODO(brianwilkerson) implement
-    return null;
+    // schedule completion analysis
+    String completionId = (_nextCompletionId++).toString();
+    var computer = new TopLevelSuggestionsComputer(server.searchEngine);
+    var future = computer.compute();
+    future.then((List<CompletionSuggestion> results) {
+      _sendSearchNotification(completionId, true, results);
+    });
+    // respond
+    return new Response(request.id)..setResult(ID, completionId);
+  }
+
+  void _sendSearchNotification(String completionId, bool isLast,

[scheglov, 2014/07/17 20:39:59]

_secondCompletionNotification?

[danrubel, 2014/07/17 21:01:14]

Done.

+      Iterable<CompletionSuggestion> results) {
+    Notification notification = new Notification(COMPLETION_RESULTS);
+    notification.setParameter(ID, completionId);
+    notification.setParameter(LAST, isLast);
+    notification.setParameter(RESULTS, results);
+    server.sendNotification(notification);
   }
 }
+
+/**
+ * A computer for `completion.getSuggestions` request results.
+ */
+class TopLevelSuggestionsComputer {

[scheglov, 2014/07/17 20:40:00]

Make it private?

[danrubel, 2014/07/17 21:01:14]

I didn't bother because I envision more of these and moving this one out into
its own file similar to the other computers you created.

+  final SearchEngine searchEngine;
+
+  TopLevelSuggestionsComputer(this.searchEngine);
+
+  /**
+   * Computes [CompletionSuggestion]s for the specified position in the source.
+   */
+  Future<List<CompletionSuggestion>> compute() {
+    var future = searchEngine.searchTopLevelDeclarations('');

[scheglov, 2014/07/17 20:40:00]

Should we use an existing prefix here?

[danrubel, 2014/07/17 21:01:14]

I want to return the complete list and let the client filter it. The user may
have typed/deleted characters by the time the notification is received by the
client. If the user is still typing/deleting within the same identifier, then I
want the results to still be usable by the client. No need for another round
trip to the server.

[scheglov, 2014/07/17 21:09:32]

OK, good point.

+    return future.then((List<SearchMatch> matches) {
+      return matches.map((SearchMatch match) {
+        return new CompletionSuggestion(match.element.displayName);
+      }).toList();
+    });
+  }
+}
+
+/**
+ * A single completion suggestion.
+ */
+class CompletionSuggestion implements HasToJson {
+  final String completion;
+
+  CompletionSuggestion(this.completion);
+
+  factory CompletionSuggestion.fromJson(Map<String, Object> json) {
+    return new CompletionSuggestion(json[COMPLETION]);
+  }
+
+  @override
+  Map<String, Object> toJson() {
+    return {
+      COMPLETION: completion
+    };
+  }
+}