Experimentally disable termination on heap corrruption in order to measure the contribution of this…

content/app/content_main_runner.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/app/content_main_runner.h"
 
 #include <stdlib.h>
 
 #include "base/allocator/allocator_extension.h"
 #include "base/at_exit.h"
@@ skipping 536 matching lines @@
 #if defined(OS_LINUX) || defined(OS_OPENBSD)
     g_fds->Set(kCrashDumpSignal,
                kCrashDumpSignal + base::GlobalDescriptors::kBaseDescriptor);
 #endif
 
 #endif  // !OS_WIN
 
     is_initialized_ = true;
     delegate_ = params.delegate;
 
-    base::EnableTerminationOnHeapCorruption();
+    if (params.enable_termination_on_heap_corruption)
+      base::EnableTerminationOnHeapCorruption();

[grt (UTC plus 2), 2014/07/30 21:05:11]

if it's okay for this to happen on line 574 instead of here, consider doing
something like this down there after the AtExitManager has been created:

  if (delegate_ &&
!delegate_->ShouldExperimentallyDisableTerminateOnHeapCorruption()) {
    base::EnableTerminationOnHeapCorruption();
  }

i haven't understood exactly what's going on here, so maybe that's tricky to do,
but it would allow you to keep the ShouldFoo check in chrome-land but do the
heap corruption thing here early in content-land.

     base::EnableTerminationOnOutOfMemory();
 
     // The exit manager is in charge of calling the dtors of singleton objects.
     // On Android, AtExitManager is set up when library is loaded.
     // On iOS, it's set up in main(), which can't call directly through to here.
     // A consequence of this is that you can't use the ctor/dtor-based
     // TRACE_EVENT methods on Linux or iOS builds till after we set this up.
 #if !defined(OS_ANDROID) && !defined(OS_IOS)
     if (!ui_task_) {
       // When running browser tests, don't create a second AtExitManager as that
@@ skipping 250 matching lines @@
 
   DISALLOW_COPY_AND_ASSIGN(ContentMainRunnerImpl);
 };
 
 // static
 ContentMainRunner* ContentMainRunner::Create() {
   return new ContentMainRunnerImpl();
 }
 
 }  // namespace content