Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 402693002: Fix v8 Windows GN build. (Closed)

Created:
6 years, 5 months ago by brettw
Modified:
6 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/external/v8.git@master
Project:
v8
Visibility:
Public.

Description

Fix v8 Windows GN build. The paths for some of the Windows-specific files was incorrect. R=jochen@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22455

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
brettw
6 years, 5 months ago (2014-07-17 17:03:35 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-17 17:07:09 UTC) #2
brettw
The CQ bit was checked by brettw@chromium.org
6 years, 5 months ago (2014-07-17 17:21:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://v8-status.appspot.com/cq/brettw@chromium.org/402693002/1
6 years, 5 months ago (2014-07-17 17:22:33 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-17 17:22:34 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 5 months ago (2014-07-17 17:22:34 UTC) #6
jochen (gone - plz use gerrit)
there's no commit bot for v8 yet
6 years, 5 months ago (2014-07-17 17:38:02 UTC) #7
jochen (gone - plz use gerrit)
Committed patchset #1 manually as r22455 (presubmit successful).
6 years, 5 months ago (2014-07-17 17:40:01 UTC) #8
brettw
6 years, 5 months ago (2014-07-17 17:58:56 UTC) #9
Message was sent while issue was closed.
thanks.

Powered by Google App Engine
This is Rietveld 408576698