Move ExtensionHostMsg_PostMessage IPC handling from

Move ExtensionHostMsg_PostMessage IPC handling from
ChromeExtensionWebContentsObserver to ChromeExtensionMessageFilter.

BUG=394383
R=jamescook@chromium.org, thestig@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283963

[James Cook, 2014-07-17 17:05:13]

LGTM. Thanks for taking care of this.

[Lei Zhang, 2014-07-17 17:56:42]

lgtm

https://codereview.chromium.org/402673003/diff/1/chrome/browser/extensions/ch...
File chrome/browser/extensions/chrome_extension_web_contents_observer.cc
(right):

https://codereview.chromium.org/402673003/diff/1/chrome/browser/extensions/ch...
chrome/browser/extensions/chrome_extension_web_contents_observer.cc:15: #include
"extensions/common/extension_messages.h"
This can be removed too.

[not at google - send to devlin, 2014-07-17 19:38:43]

Turns out I also needed to post that operation to the UI thread. The diff is
insignificant.

https://codereview.chromium.org/402673003/diff/1/chrome/browser/extensions/ch...
File chrome/browser/extensions/chrome_extension_web_contents_observer.cc
(right):

https://codereview.chromium.org/402673003/diff/1/chrome/browser/extensions/ch...
chrome/browser/extensions/chrome_extension_web_contents_observer.cc:15: #include
"extensions/common/extension_messages.h"
On 2014/07/17 17:56:42, Lei Zhang wrote:
> This can be removed too.

Done.

[not at google - send to devlin, 2014-07-17 19:38:47]

The CQ bit was checked by kalman@chromium.org

[commit-bot: I haz the power, 2014-07-17 19:41:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kalman@chromium.org/402673003/20001

[Lei Zhang, 2014-07-17 20:48:42]

Can't you use ChromeExtensionMessageFilter::OverrideThreadForMessage() to get
your messages on the correct thread?

[not at google - send to devlin, 2014-07-17 20:49:24]

On 2014/07/17 20:48:42, Lei Zhang wrote:
> Can't you use ChromeExtensionMessageFilter::OverrideThreadForMessage() to get
> your messages on the correct thread?

I didn't look into it, the change I made was bringing it inline with the other
messaging IPCs.

[not at google - send to devlin, 2014-07-17 20:51:49]

On 2014/07/17 20:49:24, kalman wrote:
> On 2014/07/17 20:48:42, Lei Zhang wrote:
> > Can't you use ChromeExtensionMessageFilter::OverrideThreadForMessage() to
get
> > your messages on the correct thread?
> 
> I didn't look into it, the change I made was bringing it inline with the other
> messaging IPCs.

ah that's because they allocate a port ID on the IO thread. close channel does
override the thead. i'll fix it, thanks.

[not at google - send to devlin, 2014-07-17 20:56:21]

done

[not at google - send to devlin, 2014-07-17 20:56:49]

https://codereview.chromium.org/402673003/diff/40001/chrome/browser/renderer_...
File chrome/browser/renderer_host/chrome_extension_message_filter.cc (right):

https://codereview.chromium.org/402673003/diff/40001/chrome/browser/renderer_...
chrome/browser/renderer_host/chrome_extension_message_filter.cc:174:
DCHECK_CURRENTLY_ON(BrowserThread::UI);
I couldn't handle it anymore.

[not at google - send to devlin, 2014-07-17 20:56:58]

The CQ bit was checked by kalman@chromium.org

[commit-bot: I haz the power, 2014-07-17 20:58:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kalman@chromium.org/402673003/40001

[Lei Zhang, 2014-07-17 20:59:46]

lgtm

[commit-bot: I haz the power, 2014-07-18 01:30:37]

Change committed as 283963