Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 402653002: Delete TimelineTracingView (Closed)

Created:
6 years, 5 months ago by yurys
Modified:
6 years, 5 months ago
Reviewers:
caseq, alph, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Delete TimelineTracingView Now that corresponding experiment was removed there is no way to see the view. Also removing TimelineFlameChartDataProvider which is not used in tracing based Timeline and we don't show flame chart in other modes. BUG=361045, 394762 R=alph@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178425

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Updated TestExpectations to include virtual/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1054 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-window-filter.html View 1 chunk +4 lines, -3 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-window-filter-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
M Source/devtools/devtools.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TimelineFlameChart.js View 1 6 chunks +9 lines, -443 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 1 3 chunks +3 lines, -9 lines 0 comments Download
D Source/devtools/front_end/timeline/TimelineTracingView.js View 1 1 chunk +0 lines, -554 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineUIUtils.js View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineUIUtilsImpl.js View 1 chunk +0 lines, -10 lines 0 comments Download
M Source/devtools/front_end/timeline/TracingTimelineUIUtils.js View 1 1 chunk +0 lines, -10 lines 0 comments Download
M Source/devtools/scripts/frontend_modules.json View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
yurys
6 years, 5 months ago (2014-07-17 15:19:04 UTC) #1
yurys
Ping
6 years, 5 months ago (2014-07-18 05:49:53 UTC) #2
alph
lgtm
6 years, 5 months ago (2014-07-18 07:46:48 UTC) #3
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 5 months ago (2014-07-18 08:35:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/402653002/40001
6 years, 5 months ago (2014-07-18 08:36:45 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-18 09:40:56 UTC) #6
yurys
6 years, 5 months ago (2014-07-18 09:42:37 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 manually as r178425 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698