Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issue 402643003: Include athena_resource in unit tests (Closed)

Created:
6 years, 5 months ago by oshima
Modified:
6 years, 5 months ago
Reviewers:
Albert Bodenhamer
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Include athena_resource in unit tests Added reminder message for ash_resources so that we don't forget to remove it when it becomes unnecessary. BUG=None R=abodenha@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284093

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M athena/athena.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M athena/main/athena_main.gyp View 1 chunk +2 lines, -0 lines 1 comment Download

Messages

Total messages: 12 (0 generated)
oshima
6 years, 5 months ago (2014-07-17 15:49:21 UTC) #1
Albert Bodenhamer
https://codereview.chromium.org/402643003/diff/40001/athena/main/athena_main.gyp File athena/main/athena_main.gyp (right): https://codereview.chromium.org/402643003/diff/40001/athena/main/athena_main.gyp#newcode18 athena/main/athena_main.gyp:18: # debug_widow.cc depends on this. Remove this once debug_window ...
6 years, 5 months ago (2014-07-17 16:05:47 UTC) #2
oshima
updated the description. I put it here because i thought creating separate CL for it ...
6 years, 5 months ago (2014-07-17 17:25:00 UTC) #3
Albert Bodenhamer
lgtm
6 years, 5 months ago (2014-07-17 18:18:00 UTC) #4
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 5 months ago (2014-07-17 18:18:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/402643003/40001
6 years, 5 months ago (2014-07-17 18:21:31 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-17 21:53:39 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-17 22:12:12 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/172123)
6 years, 5 months ago (2014-07-17 22:12:13 UTC) #9
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 5 months ago (2014-07-18 14:17:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/402643003/40001
6 years, 5 months ago (2014-07-18 14:20:41 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 14:24:02 UTC) #12
Message was sent while issue was closed.
Change committed as 284093

Powered by Google App Engine
This is Rietveld 408576698