Do not wrap the bugs column on the flakiness dashboard

Do not wrap the bugs column on the flakiness dashboard

The flakiness dashboard forces different whites-space handling for the
bugs column to handle long bugs. When the dashboard is narrow due to
the screen being narrow or the flakiness runs being longer than the
page (common after [1]), the wrapped "File new bug" text causes every
row to be tall and ugly (see: http://pr.gg/longbug.png). This patch
changes the new bug text to be nowrap.

The original code for longbug handling was added before
TestExpectations was as clean as it is today.

[1] https://codereview.chromium.org/359533004/

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178396

[ojan, 2014-07-17 17:36:35]

Seems to me that this would still be a problem for tests with multiple bugs,
e.g.
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40...

How about we instead make just the file new bug link nowrap?

[pdr., 2014-07-17 17:40:47]

On 2014/07/17 17:36:35, ojan-only-code-yellow-reviews wrote:
> Seems to me that this would still be a problem for tests with multiple bugs,
> e.g.
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40...
> 
> How about we instead make just the file new bug link nowrap?

It ends up not being a problem because we put each link in a div, so the lines
still break properly. Making the "file a bug" link nowrap is cleaner long-term
though, so let me give that a shot.

[pdr., 2014-07-17 17:53:38]

On 2014/07/17 17:40:47, pdr wrote:
> On 2014/07/17 17:36:35, ojan-only-code-yellow-reviews wrote:
> > Seems to me that this would still be a problem for tests with multiple bugs,
> > e.g.
> >
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40...
> > 
> > How about we instead make just the file new bug link nowrap?
> 
> It ends up not being a problem because we put each link in a div, so the lines
> still break properly. Making the "file a bug" link nowrap is cleaner long-term
> though, so let me give that a shot.

Yeah, your idea is much cleaner. I've updated the patch and change description.
PTAL

[ojan, 2014-07-17 18:28:56]

I didn't understand that we put each link in a div. I actually prefer your first
patch in that case. :) nth-child selectors are gross.

Either patch LGTM.

[pdr., 2014-07-17 18:32:50]

On 2014/07/17 18:28:56, ojan-only-code-yellow-reviews wrote:
> I didn't understand that we put each link in a div. I actually prefer your
first
> patch in that case. :) nth-child selectors are gross.
> 
> Either patch LGTM.

Lets go with the latest patch and remove the extra divs at some point.

[pdr., 2014-07-17 18:32:54]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2014-07-17 18:33:58]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pdr@chromium.org/402643002/20001

[pdr., 2014-07-17 18:59:39]

On 2014/07/17 18:33:58, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-status.appspot.com/cq/pdr@chromium.org/402643002/20001

Fail :( Forgot to NOTRY=true

[commit-bot: I haz the power, 2014-07-17 20:20:39]

Change committed as 178396