Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(954)

Unified Diff: Source/devtools/front_end/timeline/TimelineTracingView.js

Issue 402633002: DevTools: Remove redundant dependency on target from TimelineFrameModel (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Address caseq comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/timeline/TimelineTracingView.js
diff --git a/Source/devtools/front_end/timeline/TimelineTracingView.js b/Source/devtools/front_end/timeline/TimelineTracingView.js
index dd7e47f36f655e8358ad7768822f0aa9962d8584..e07032b96a83b066801d712c1bd8588585461757 100644
--- a/Source/devtools/front_end/timeline/TimelineTracingView.js
+++ b/Source/devtools/front_end/timeline/TimelineTracingView.js
@@ -117,12 +117,10 @@ WebInspector.TimelineTracingView.prototype = {
contentHelper.appendTextRow(WebInspector.UIString("Duration"), Number.millisToString(record.duration, true));
if (!Object.isEmpty(record.args))
contentHelper.appendElementRow(WebInspector.UIString("Arguments"), this._formatArguments(record.args));
- /**
- * @this {WebInspector.TimelineTracingView}
- */
+
function reveal()
{
- WebInspector.Revealer.reveal(new WebInspector.DeferredTracingLayerTree(this._tracingModel.target().weakReference(), record.args["snapshot"]["active_tree"]["root_layer"], record.args["snapshot"]["device_viewport_size"]));
+ WebInspector.Revealer.reveal(new WebInspector.DeferredTracingLayerTree(record.thread.target(), record.args["snapshot"]["active_tree"]["root_layer"], record.args["snapshot"]["device_viewport_size"]));
}
/**
* @param {!Node=} node
@@ -143,7 +141,7 @@ WebInspector.TimelineTracingView.prototype = {
var link = document.createElement("span");
link.classList.add("revealable-link");
link.textContent = "show";
- link.addEventListener("click", reveal.bind(this), false);
+ link.addEventListener("click", reveal, false);
contentHelper.appendElementRow(WebInspector.UIString("Layer tree"), link);
// Fall-through intended.
default:
« no previous file with comments | « Source/devtools/front_end/timeline/TimelinePanel.js ('k') | Source/devtools/front_end/timeline/TracingModel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698