Issue 402633002: DevTools: Remove redundant dependency on target from TimelineFrameModel

Issue 402633002: DevTools: Remove redundant dependency on target from TimelineFrameModel (Closed)

Created:
6 years, 5 months ago by sergeyv

Modified:
6 years, 5 months ago

Reviewers:
caseq, yurys

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: Remove redundant dependency on target from TimelineFrameModel BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178384

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Remove weakptrs on target #

Total comments: 4

Patch Set 3 : Address caseq comments #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+86 lines, -98 lines)			Patch
M	LayoutTests/inspector/timeline/timeline-layer-tree-snapshot.html	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/sdk/LayerTreeModel.js	View	1 2	16 chunks	+47 lines, -39 lines	0 comments	Download
M	Source/devtools/front_end/sdk/PaintProfiler.js	View	1	7 chunks	+10 lines, -27 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TimelineFrameModel.js	View	1	5 chunks	+8 lines, -17 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TimelineLayersView.js	View	1	2 chunks	+5 lines, -7 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TimelinePanel.js	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TimelineTracingView.js	View	1	2 chunks	+3 lines, -5 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TracingModel.js	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

caseq

Generally looks good, but let's fix the way we pass target. https://codereview.chromium.org/402633002/diff/20001/Source/devtools/front_end/timeline/TimelineFrameModel.js File Source/devtools/front_end/timeline/TimelineFrameModel.js (right): ...

6 years, 5 months ago (2014-07-17 12:30:36 UTC) #2

sergeyv

https://codereview.chromium.org/402633002/diff/20001/Source/devtools/front_end/timeline/TimelineFrameModel.js File Source/devtools/front_end/timeline/TimelineFrameModel.js (right): https://codereview.chromium.org/402633002/diff/20001/Source/devtools/front_end/timeline/TimelineFrameModel.js#newcode412 Source/devtools/front_end/timeline/TimelineFrameModel.js:412: this.handleLayerTreeSnapshot(new WebInspector.DeferredTracingLayerTree(target ? target.weakReference() : new WeakReference(null), event.args["snapshot"]["active_tree"]["root_layer"], event.args["snapshot"]["device_viewport_size"])); ...

6 years, 5 months ago (2014-07-17 14:34:29 UTC) #3

caseq

lgtm, but please fix the callback invocation upon early bail out. https://codereview.chromium.org/402633002/diff/40001/Source/devtools/front_end/sdk/LayerTreeModel.js File Source/devtools/front_end/sdk/LayerTreeModel.js (right): ...

6 years, 5 months ago (2014-07-17 14:41:18 UTC) #4

sergeyv

https://codereview.chromium.org/402633002/diff/40001/Source/devtools/front_end/sdk/LayerTreeModel.js File Source/devtools/front_end/sdk/LayerTreeModel.js (right): https://codereview.chromium.org/402633002/diff/40001/Source/devtools/front_end/sdk/LayerTreeModel.js#newcode747 Source/devtools/front_end/sdk/LayerTreeModel.js:747: if (!this._target) On 2014/07/17 14:41:18, caseq wrote: > We ...

6 years, 5 months ago (2014-07-17 15:09:22 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/402633002/60001

6 years, 5 months ago (2014-07-17 15:10:41 UTC) #7

Message was sent while issue was closed.

Change committed as 178384

Expand Messages | Collapse Messages