Issue 402613010: Fix DOM KeyboardEvent 'repeat' state

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 402613010: Fix DOM KeyboardEvent 'repeat' state (Closed)

Created:
6 years, 5 months ago by jsbell

Modified:
6 years, 5 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix DOM KeyboardEvent 'repeat' state The 'repeat' state of a DOM KeyboardEvent was always false. The Aura->blink event modifier mapper was not plumbing it through. Do so! BUG=263724, 394907 TEST=document.body.onkeydown=function(e){console.log(e.repeat);}; Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284263

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	content/browser/renderer_host/ui_events_helper.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	content/browser/renderer_host/web_input_event_aurax11.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jsbell

ben@ - seems to fix the issue with limited testing on my Linux box. First ...

6 years, 5 months ago (2014-07-17 21:22:05 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/402613010/1

6 years, 5 months ago (2014-07-18 21:47:38 UTC) #4

Message was sent while issue was closed.

Change committed as 284263

Expand Messages | Collapse Messages