Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 402613008: Update targetSdkVersion to 20. (Closed)

Created:
6 years, 5 months ago by aurimas (slooooooooow)
Modified:
6 years, 5 months ago
CC:
chromium-reviews, darin (slow to review), cbentzel+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, android-webview-reviews_chromium.org, Aaron Boodman, darin-cc_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, abarth-chromium, ben+mojo_chromium.org, stgao, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update targetSdkVersion to 20. Applications targeting this or a later release will get these new changes in behavior: - AlertDialog might not have a default background if the theme does not specify one. BUG=393019 TBR=stgao@chromium.org,blundell@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284131

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Undo version change for webview due to failing tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M build/android/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/shell/java/AndroidManifest.xml View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/shell/javatests/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/android/unit_tests_apk/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/test/webview_shell/java/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/sample/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/sample/javatests/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/android/browsertests_apk/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/android/javatests/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/android/linker_test_apk/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/android/shell_apk/AndroidManifest.xml View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/android/javatests/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/android/apk/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M testing/android/java/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (0 generated)
aurimas (slooooooooow)
PTAL
6 years, 5 months ago (2014-07-17 17:54:48 UTC) #1
aurimas (slooooooooow)
boliu@chromium.org: Please review changes in android_webview/*
6 years, 5 months ago (2014-07-17 17:55:10 UTC) #2
aurimas (slooooooooow)
viettrungluu@chromium.org: Please review changes in mojo/
6 years, 5 months ago (2014-07-17 17:56:13 UTC) #3
Yaron
lgtm
6 years, 5 months ago (2014-07-17 17:56:50 UTC) #4
Yaron
On 2014/07/17 17:56:50, Yaron wrote: > lgtm you also need an owner for components/cronet
6 years, 5 months ago (2014-07-17 17:57:07 UTC) #5
boliu
lgtm
6 years, 5 months ago (2014-07-17 17:59:30 UTC) #6
aurimas (slooooooooow)
stgao@chromium.org: Please review changes in chrome/test/chromedriver/ blundell@chromium.org: Please review changes in components/
6 years, 5 months ago (2014-07-17 17:59:41 UTC) #7
viettrungluu
mojo/ lgtm
6 years, 5 months ago (2014-07-17 20:13:15 UTC) #8
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 5 months ago (2014-07-18 01:28:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/402613008/1
6 years, 5 months ago (2014-07-18 01:31:50 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-18 05:45:18 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-18 06:11:08 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/172469)
6 years, 5 months ago (2014-07-18 06:11:09 UTC) #13
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 5 months ago (2014-07-18 16:48:24 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/402613008/1
6 years, 5 months ago (2014-07-18 16:49:32 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-18 16:55:03 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-18 16:57:56 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/172500)
6 years, 5 months ago (2014-07-18 16:57:57 UTC) #18
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 5 months ago (2014-07-18 17:01:47 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/402613008/40001
6 years, 5 months ago (2014-07-18 17:03:15 UTC) #20
commit-bot: I haz the power
Change committed as 284131
6 years, 5 months ago (2014-07-18 17:05:38 UTC) #21
blundell
6 years, 5 months ago (2014-07-21 14:16:00 UTC) #22
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698