Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 402613003: Remove use of SK_SUPPORT_LEGACY_LAYERRASTERIZER_API. (Closed)

Created:
6 years, 5 months ago by Dominik Grewe
Modified:
6 years, 5 months ago
Reviewers:
scroggo, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove use of SK_SUPPORT_LEGACY_LAYERRASTERIZER_API. Mozilla have removed any uses of the legacy API from their Moz2D code. Since they were the last users we know of, we can remove the legacy API. BUG=skia:2187 Committed: https://skia.googlesource.com/skia/+/1bd6f7de5273f56a361a5b29ac9b448a525f0b9b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -39 lines) Patch
M include/effects/SkLayerRasterizer.h View 2 chunks +1 line, -22 lines 0 comments Download
M src/core/SkPaintPriv.cpp View 1 chunk +1 line, -6 lines 0 comments Download
M src/effects/SkLayerRasterizer.cpp View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Dominik Grewe
ptal, thanks!
6 years, 5 months ago (2014-07-17 10:38:06 UTC) #1
scroggo
lgtm
6 years, 5 months ago (2014-07-17 13:17:53 UTC) #2
scroggo
On 2014/07/17 13:17:53, scroggo wrote: > lgtm nit: Message should say: BUG=skia:2187
6 years, 5 months ago (2014-07-17 13:18:36 UTC) #3
reed1
lgtm
6 years, 5 months ago (2014-07-17 13:18:37 UTC) #4
reed1
The CQ bit was unchecked by reed@google.com
6 years, 5 months ago (2014-07-17 13:19:07 UTC) #5
reed1
The CQ bit was checked by reed@google.com
6 years, 5 months ago (2014-07-17 13:19:12 UTC) #6
reed1
The CQ bit was unchecked by reed@google.com
6 years, 5 months ago (2014-07-17 13:19:19 UTC) #7
reed1
The CQ bit was checked by reed@google.com
6 years, 5 months ago (2014-07-17 13:19:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/dominikg@chromium.org/402613003/1
6 years, 5 months ago (2014-07-17 13:20:33 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-19 01:21:04 UTC) #10
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 5 months ago (2014-07-19 01:21:05 UTC) #11
Dominik Grewe
The CQ bit was checked by dominikg@chromium.org
6 years, 5 months ago (2014-07-21 09:39:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/dominikg@chromium.org/402613003/1
6 years, 5 months ago (2014-07-21 09:39:29 UTC) #13
commit-bot: I haz the power
6 years, 5 months ago (2014-07-21 09:43:25 UTC) #14
Message was sent while issue was closed.
Change committed as 1bd6f7de5273f56a361a5b29ac9b448a525f0b9b

Powered by Google App Engine
This is Rietveld 408576698