Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2834)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Tools/GardeningServer/scripts/svn-log_unittests.js

Issue 402603007: Get sheriff-o-matic data from auto-sheriff.appspot.com. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: address review comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Tools/GardeningServer/scripts/svn-log.js ('k') | Tools/GardeningServer/ui/ct-builder-grid.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/GardeningServer/scripts/svn-log_unittests.js
diff --git a/Tools/GardeningServer/scripts/svn-log_unittests.js b/Tools/GardeningServer/scripts/svn-log_unittests.js
deleted file mode 100644
index e6122647a926a40ca0f706b5dd6c198c7f8b5070..0000000000000000000000000000000000000000
--- a/Tools/GardeningServer/scripts/svn-log_unittests.js
+++ /dev/null
@@ -1,292 +0,0 @@
-/*
- * Copyright (C) 2011 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- * notice, this list of conditions and the following disclaimer in the
- * documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
- * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
- * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
- * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
- * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
- * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
- * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
- * THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-(function () {
-
-module("svn-log");
-
-var kExampleCommitDataXML =
- "<feed xmlns='http://www.w3.org/2005/Atom'>\n" +
- "<title>blink, branch master</title>\n" +
- "<subtitle>Mirror of the Chromium Blink repository.</subtitle>\n" +
- "<link rel='alternate' type='text/html' href='http://blink.lc/blink/'/>\n" +
- "<entry>\n" +
- "<title>Throw SecurityError when setting 'Replaceable' properties cross-origin.</title>\n" +
- "<updated>2013-09-30T20:22:01Z</updated>\n" +
- "<author>\n" +
- "<name>mkwst@chromium.org</name>\n" +
- "</author>\n" +
- "<published>2013-09-30T20:22:01Z</published>\n" +
- "<link rel='alternate' type='text/html' href='http://blink.lc/blink/commit/?id=723e62a4a4e093435b4772b4839aa3fd7cf6b991'/>\n" +
- "<id>723e62a4a4e093435b4772b4839aa3fd7cf6b991</id>\n" +
- "<content type='text'>\n" +
- "This matches Gecko's behavior for these types of properties.\n" +
- "\n" +
- "BUG=17325\n" +
- "R=jochen@chromium.org\n" +
- "CC=abarth@chromium.org\n" +
- "\n" +
- "Review URL: https://chromiumcodereview.appspot.com/25022002\n" +
- "\n" +
- "git-svn-id: svn://svn.chromium.org/blink/trunk@158545 bbb929c8-8fbe-4397-9dbb-9b2b20218538\n" +
- "</content>\n" +
- "<content type='xhtml'>\n" +
- "<div xmlns='http://www.w3.org/1999/xhtml'>\n" +
- "<pre>\n" +
- "This matches Gecko's behavior for these types of properties.\n" +
- "\n" +
- "BUG=17325\n" +
- "R=jochen@chromium.org\n" +
- "CC=abarth@chromium.org\n" +
- "\n" +
- "Review URL: https://chromiumcodereview.appspot.com/25022002\n" +
- "\n" +
- "git-svn-id: svn://svn.chromium.org/blink/trunk@158545 bbb929c8-8fbe-4397-9dbb-9b2b20218538\n" +
- "</pre>\n" +
- "</div>\n" +
- "</content>\n" +
- "</entry>\n" +
- "<entry>\n" +
- "<title>Fix one more layering violation caught by check-blink-deps</title>\n" +
- "<updated>2013-09-30T19:36:21Z</updated>\n" +
- "<author>\n" +
- "<name>eseidel@chromium.org</name>\n" +
- "</author>\n" +
- "<published>2013-09-30T19:36:21Z</published>\n" +
- "<link rel='alternate' type='text/html' href='http://blink.lc/blink/commit/?id=51e5c70050dcb0980eb31f112d0cd948f3ece820'/>\n" +
- "<id>51e5c70050dcb0980eb31f112d0cd948f3ece820</id>\n" +
- "<content type='text'>\n" +
- "core/platform may not depend on core/ even for testing.\n" +
- "\n" +
- "BUG=301947\n" +
- "TBR=abarth@chromium.org, abarth\n" +
- "\n" +
- "Review URL: https://codereview.chromium.org/25284004\n" +
- "\n" +
- "git-svn-id: svn://svn.chromium.org/blink/trunk@158544 bbb929c8-8fbe-4397-9dbb-9b2b20218538\n" +
- "</content>\n" +
- "<content type='xhtml'>\n" +
- "<div xmlns='http://www.w3.org/1999/xhtml'>\n" +
- "<pre>\n" +
- "core/platform may not depend on core/ even for testing.\n" +
- "\n" +
- "BUG=301947\n" +
- "TBR=abarth@chromium.org, abarth\n" +
- "\n" +
- "Review URL: https://codereview.chromium.org/25284004\n" +
- "\n" +
- "git-svn-id: svn://svn.chromium.org/blink/trunk@158544 bbb929c8-8fbe-4397-9dbb-9b2b20218538\n" +
- "</pre>\n" +
- "</div>\n" +
- "</content>\n" +
- "</entry>\n" +
- "<entry>\n" +
- "<title>Update DEPS include_rules after addition of root-level platform directory</title>\n" +
- "<updated>2013-09-30T19:28:49Z</updated>\n" +
- "<author>\n" +
- "<name>eseidel@chromium.org</name>\n" +
- "</author>\n" +
- "<published>2013-09-30T19:28:49Z</published>\n" +
- "<link rel='alternate' type='text/html' href='http://blink.lc/blink/commit/?id=227add0156e8ab272abcd3368dfc0b5a91f35749'/>\n" +
- "<id>227add0156e8ab272abcd3368dfc0b5a91f35749</id>\n" +
- "<content type='text'>\n" +
- "These were all failures noticed when running check-blink-deps\n" +
- "\n" +
- "R=abarth@chromium.org,abarth,abarth\n" +
- "BUG=301947\n" +
- "\n" +
- "Review URL: https://codereview.chromium.org/25275005\n" +
- "\n" +
- "git-svn-id: svn://svn.chromium.org/blink/trunk@158543 bbb929c8-8fbe-4397-9dbb-9b2b20218538\n" +
- "</content>\n" +
- "<content type='xhtml'>\n" +
- "<div xmlns='http://www.w3.org/1999/xhtml'>\n" +
- "<pre>\n" +
- "These were all failures noticed when running check-blink-deps\n" +
- "\n" +
- "R=abarth@chromium.org,abarth,abarth\n" +
- "BUG=301947\n" +
- "\n" +
- "Review URL: https://codereview.chromium.org/25275005\n" +
- "\n" +
- "git-svn-id: svn://svn.chromium.org/blink/trunk@158543 bbb929c8-8fbe-4397-9dbb-9b2b20218538\n" +
- "</pre>\n" +
- "</div>\n" +
- "</content>\n" +
- "<entry>\n" +
- "<title>Mark Skia suppressions for rebasline.</title>\n" +
- "<updated>2014-02-27T14:44:41Z</updated>\n" +
- "<author>\n" +
- "<name>fmalita@chromium.org</name>\n" +
- "</author>\n" +
- "<published>2014-02-27T14:44:41Z</published>\n" +
- "<link rel='alternate' type='text/html' href='http://blink.lc/blink/commit/?id=35030357db3c0967974273faf5e65fe3d7cc041b'/>\n" +
- "<id>35030357db3c0967974273faf5e65fe3d7cc041b</id>\n" +
- "<content type='text'>\n" +
- "Unreviewed gardening.\n" +
- "Stray R=123 in the middle...\n" +
- "\n" +
- "BUG=/341448,344497\n" +
- "TBR=robertphillips@google.com\n" +
- "\n" +
- "Review URL: https://codereview.chromium.org/183123002\n" +
- "\n" +
- "git-svn-id: svn://svn.chromium.org/blink/trunk@168027 bbb929c8-8fbe-4397-9dbb-9b2b20218538\n" +
- "</content>\n" +
- "<content type='xhtml'>\n" +
- "<div xmlns='http://www.w3.org/1999/xhtml'>\n" +
- "<pre>\n" +
- "Unreviewed gardening.\n" +
- "Stray R=123 in the middle...\n" +
- "\n" +
- "BUG=/341448 , 344497/ \n" +
- "TBR=robertphillips@google.com\n" +
- "\n" +
- "Review URL: https://codereview.chromium.org/183123002\n" +
- "\n" +
- "git-svn-id: svn://svn.chromium.org/blink/trunk@168027 bbb929c8-8fbe-4397-9dbb-9b2b20218538\n" +
- "</pre>\n" +
- "</div>\n" +
- "</content>\n" +
- "</entry>\n" +
-
- "<entry>\n" +
- "<title>Remove yurys and loislo from WTF watchlist</title>\n" +
- "<updated>2014-03-03T07:23:31Z</updated>\n" +
- "<author>\n" +
- "<name>yurys@chromium.org</name>\n" +
- "</author>\n" +
- "<published>2014-03-03T07:23:31Z</published>\n" +
- "<link rel='alternate' type='text/html' href='http://blink.lc/blink/commit/?id=43118424ccd1d65ea7ec9ba26c32195e5fdde6e4'/>\n" +
- "<id>43118424ccd1d65ea7ec9ba26c32195e5fdde6e4</id>\n" +
- "<content type='text'>\n" +
- "BUG=None\n" +
- "R=loislo@chromium.org\n" +
- "\n" +
- "Review URL: https://codereview.chromium.org/176883013\n" +
- "\n" +
- "git-svn-id: svn://svn.chromium.org/blink/trunk@168268 bbb929c8-8fbe-4397-9dbb-9b2b20218538\n" +
- "</content>\n" +
- "<content type='xhtml'>\n" +
- "<div xmlns='http://www.w3.org/1999/xhtml'>\n" +
- "<pre>\n" +
- "BUG=None\n" +
- "R=loislo@chromium.org\n" +
- "\n" +
- "Review URL: https://codereview.chromium.org/176883013\n" +
- "\n" +
- "git-svn-id: svn://svn.chromium.org/blink/trunk@168268 bbb929c8-8fbe-4397-9dbb-9b2b20218538\n" +
- "</pre>\n" +
- "</div>\n" +
- "</content>\n" +
- "</entry>\n" +
- "</feed>\n";
-
-var kExampleCommitDataList = [{
- "revision": 158545,
- "title": "Throw SecurityError when setting 'Replaceable' properties cross-origin.",
- "time": "2013-09-30T20:22:01Z",
- "summary": "This matches Gecko's behavior for these types of properties.",
- "author": "mkwst@chromium.org",
- "reviewer": "jochen@chromium.org",
- "bugID": [17325],
- "revertedRevision": undefined
- },
- {
- "revision": 158544,
- "title": "Fix one more layering violation caught by check-blink-deps",
- "time": "2013-09-30T19:36:21Z",
- "summary": "core/platform may not depend on core/ even for testing.",
- "author": "eseidel@chromium.org",
- "reviewer": "abarth@chromium.org, abarth",
- "bugID": [301947],
- "revertedRevision": undefined
- },
- {
- "revision": 158543,
- "title": "Update DEPS include_rules after addition of root-level platform directory",
- "time": "2013-09-30T19:28:49Z",
- "summary": "These were all failures noticed when running check-blink-deps",
- "author": "eseidel@chromium.org",
- "reviewer": "abarth@chromium.org, abarth, abarth",
- "bugID": [301947],
- "revertedRevision": undefined
- },
- {
- "revision": 168027,
- "title": "Mark Skia suppressions for rebasline.",
- "time": "2014-02-27T14:44:41Z",
- "summary": "Unreviewed gardening.",
- "author": "fmalita@chromium.org",
- "reviewer": "robertphillips@google.com",
- "bugID": [341448, 344497],
- "revertedRevision": undefined
- },
- {
- "revision": 168268,
- "title": "Remove yurys and loislo from WTF watchlist",
- "time": "2014-03-03T07:23:31Z",
- "summary": "BUG=None",
- "author": "yurys@chromium.org",
- "reviewer": "loislo@chromium.org",
- "bugID": null,
- "revertedRevision": undefined
- }
-];
-
-test("queryParam", 2, function() {
- equal(trac._queryParam({}), '');
- equal(trac._queryParam({
- 'foo bar': 'bar baz',
- '1 2': '3 4',
- }), 'foo+bar=bar+baz&1+2=3+4');
-});
-
-test("changesetURL", 1, function() {
- equals(trac.changesetURL(1234), "http://src.chromium.org/viewvc/blink?view=rev&revision=1234");
-});
-
-asyncTest("recentCommitData", 3, function() {
- var simulator = new NetworkSimulator();
- simulator.xml = function(url)
- {
- equals(url, 'http://blink.lc/blink/atom');
- var parser = new DOMParser();
- var responseDOM = parser.parseFromString(kExampleCommitDataXML, "application/xml");
- return Promise.resolve(responseDOM);
- };
-
- simulator.runTest(function() {
- return trac.recentCommitData('trunk', 10).then(function(commitDataList) {
- commitDataList.forEach(function(commitData) {
- // Including the entire message makes the deepEqual below to unwieldy.
- delete commitData.message;
- });
- deepEqual(commitDataList, kExampleCommitDataList);
- });
- }).then(start);
-});
-
-})();
« no previous file with comments | « Tools/GardeningServer/scripts/svn-log.js ('k') | Tools/GardeningServer/ui/ct-builder-grid.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698