Get sheriff-o-matic data from auto-sheriff.appspot.com.

Tools/GardeningServer/model/ct-commit.html

 <!--
 Copyright 2014 The Chromium Authors. All rights reserved.
 Use of this source code is governed by a BSD-style license that can be
 found in the LICENSE file.
 -->
 
 <script>
-function CTCommit(author, message) {
+function CTCommit(author, message, baseUrl) {

[ojan, 2014/07/21 00:44:56]

I can split these changes out to a different patch if it's too confusing. This
is just moving code from svn-log.js to here. Making this change allowed for
deleting all of svn-log.js.

   this.author = author;
   this.message = message.trim();
   this.revision = this._findRevision();
   this.summary = this.message.split('\n')[0];
+  this._baseUrl = baseUrl;
+}
+
+CTCommit.prototype.url = function() {

[abarth-chromium, 2014/07/21 06:44:17]

Getter?

[ojan, 2014/07/21 22:46:13]

I really dislike getters. They make for surprising code because you never expect
a getter to be doing a bunch of work. I'm torn in this case because getters let
you interface better with MDV. I'll switch it over. I don't even know the right
syntax for getters...is Object.defineProperty the right way to set a getter on
the prototype?

+  var queryParameters = {
+    view: 'rev',
+    revision: this.revision,
+  };
+  return this._baseUrl + '?' + CTCommit._queryParam(queryParameters);
+}
+
+// FIXME: This should live somewhere better so it can be reused.
+CTCommit._queryParam = function(params) {

[abarth-chromium, 2014/07/21 06:44:17]

Object.toQueryString from sugar

[ojan, 2014/07/21 22:46:13]

Not sure how I missed that.

+  var result = []
+  Object.keys(params, function(key, value) {
+    result.push(encodeURIComponent(key) + '=' + encodeURIComponent(value));
+  });
+  return result.join('&');
 }
 
 CTCommit.prototype._findRevision = function(message) {
   var regexp = /git-svn-id: svn:\/\/svn.chromium.org\/blink\/trunk@(\d+)/;
   var match = regexp.exec(this.message);
   if (match)
     return parseInt(match[1], 10);
   return null;
 }
-</script>
+</script>