Chromium Code Reviews Chromium Code Reviews
Issue 402603005:
Disable touch highlight when the touched node has no hand-cursor. (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: LayoutTests/compositing/gestures/gesture-tapHighlight-nested-cursor.html |
| diff --git a/LayoutTests/compositing/gestures/gesture-tapHighlight-simple-div-boxshadow-fixed-nested2.html b/LayoutTests/compositing/gestures/gesture-tapHighlight-nested-cursor.html |
| similarity index 63% |
| copy from LayoutTests/compositing/gestures/gesture-tapHighlight-simple-div-boxshadow-fixed-nested2.html |
| copy to LayoutTests/compositing/gestures/gesture-tapHighlight-nested-cursor.html |
| index 5b96fdc32394990f19cc6290d1c7d9dbf99e4524..5801e9d3c45a8c33093a15b15cb42105dfa6e391 100644 |
| --- a/LayoutTests/compositing/gestures/gesture-tapHighlight-simple-div-boxshadow-fixed-nested2.html |
| +++ b/LayoutTests/compositing/gestures/gesture-tapHighlight-nested-cursor.html |
| @@ -2,19 +2,23 @@ |
| <html> |
|
Rick Byers
2014/07/24 18:29:36
Note that someday we should perhaps update all the
mustaq
2014/07/29 18:34:50
Acknowledged.
|
| <head> |
| <script src="../../resources/js-test.js"></script> |
| -<script src="resources/target-div-run-test.js"></script> |
| <link rel="stylesheet" type="text/css" href="resources/link-highlight-style.css"> |
| </head> |
| <body onload="runTest();"> |
| -<div style="position: absolute; top: 10px; left: 10px; -webkit-transform: translateZ(0);"> |
| -<div style="position: relative; top: 10px; left: 25px;"> |
| -<div class="opaqueHighlight" id="targetDiv" style="position: fixed; left: 50px; top: 50px; width: 50px; height: 50px; box-shadow: 0px 4px 23px 5px rgba(0, 0, 0, 0.2); border-style: solid; border-width: 2px; cursor: Pointer"> |
| -<br><center>Target</center><br> |
| +<div class="opaqueHighlight" id="targetDiv" style="position: fixed; top: 100px; left: 10px; width: 350px; height: 110px; border-style: solid; cursor: pointer; font-size: x-small"> |
| +pointer |
| +<div style="position: fixed; top: 110px; left: 60px; width: 250px; height: 90px; border-style: solid; cursor: pointer;"> |
| +pointer |
| +<div style="position: fixed; top: 120px; left: 110px; width: 150px; height: 70px; border-style: solid; cursor: default;"> |
| +default |
| +<div style="position: fixed; top: 130px; left: 160px; width: 50px; height: 50px; border-style: solid;"> |
| +none |
|
Rick Byers
2014/07/24 18:29:36
All this explicit positioning makes this test hard
mustaq
2014/07/29 18:34:50
Done. Thanks!
|
| +</div> |
| </div> |
| </div> |
| </div> |
| <div style="position: absolute; left: 10px; top: 250px; -webkit-transform: translateZ(0);"> |
|
Rick Byers
2014/07/24 18:29:36
Does this div do anything? Can you just remove it
mustaq
2014/07/29 18:34:50
I added it to be consistent with other tests here
wjmaclean
2014/07/29 20:33:38
Once upon a time this used to be necessary to guar
|
| -This test is successful if the box labelled "Target" has a green rectangle centered on it. |
| +This test is successful if there is no green rectangle above. |
| </div> |
| <script> |
| function runTest() { |
| @@ -34,6 +38,5 @@ function runTest() { |
| } |
| } |
| </script> |
| -</script> |
| </body> |
| </html> |
