Disable touch highlight when the touched node has no hand-cursor.

Source/web/WebViewImpl.cpp

Index: Source/web/WebViewImpl.cpp
diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp
index 54d1d2a3cfd71b0e11b7ce90e7df350530cdd8e8..3fdee13835eec25431bf0ff677b707301f410a73 100644
--- a/Source/web/WebViewImpl.cpp
+++ b/Source/web/WebViewImpl.cpp
@@ -1194,12 +1194,8 @@ Node* WebViewImpl::bestTapNode(const PlatformGestureEvent& tapEvent)
     while (bestTouchNode && !bestTouchNode->renderer())
         bestTouchNode = bestTouchNode->parentNode();
 
-    // Check if we're in the subtree of a node with a hand cursor
-    // this is the heuristic we use to determine if we show a highlight on tap
-    while (bestTouchNode && !invokesHandCursor(bestTouchNode, m_page->deprecatedLocalMainFrame()))
-        bestTouchNode = bestTouchNode->parentNode();
-
-    if (!bestTouchNode)
+    // The heuristic we use is: show a highlight on tap only when we are at a node with a hand cursor

[Rick Byers, 2014/07/17 21:19:03]

I don't think this is quite what we want.  If the node has a hand cursor, then
we want to walk up the tree and find the node that invokes that hand cursor and
use that for the highlight.  So we still need to the treewalk, but we need to
somehow exclude nodes where the cursor has been explicitly reset to something
else.

+    if (!bestTouchNode || !invokesHandCursor(bestTouchNode, m_page->deprecatedLocalMainFrame()))
         return 0;
 
     // We should pick the largest enclosing node with hand cursor set.