Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 402593002: Document when (and when not) to use reportFatalError. (Closed)

Created:
6 years, 5 months ago by ahe
Modified:
6 years, 4 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, compiler-dev_dartlang.org
Visibility:
Public.

Description

Document when (and when not) to use reportFatalError. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=39139

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M dart/sdk/lib/_internal/compiler/implementation/compiler.dart View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ahe
6 years, 5 months ago (2014-07-17 10:09:05 UTC) #1
Johnni Winther
lgtm
6 years, 5 months ago (2014-07-17 10:38:50 UTC) #2
ahe
6 years, 4 months ago (2014-08-12 14:03:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 39139 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698