Separate GeolocationWatchers from Geolocation

Source/modules/geolocation/GeoNotifier.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef GeoNotifier_h
 #define GeoNotifier_h
 
+#include "modules/geolocation/PositionCallback.h"
+#include "modules/geolocation/PositionErrorCallback.h"

[Michael van Ouwerkerk, 2014/07/18 12:07:39]

These changes do not seem necessary. Using forward declarations is a good thing.

[kihong, 2014/07/18 14:28:24]

It's better to use forward declarations, but we cannot do that because these are
working with OwnPtr.
They makes build error when it included by GeolocationWhatcher.cpp.
If we change OwnPtr to Member, we could use forward declarations but current
callback implementation using code generator only support OwnPtr.
That's why I changed them to "include" instead of forward declarations. 

 #include "platform/Timer.h"
 #include "platform/heap/Handle.h"
 
 namespace WebCore {
 
 class Geolocation;
 class Geoposition;
-class PositionCallback;
 class PositionError;
-class PositionErrorCallback;
 class PositionOptions;
 
 class GeoNotifier : public GarbageCollectedFinalized<GeoNotifier> {
 public:
     static GeoNotifier* create(Geolocation* geolocation, PassOwnPtr<PositionCallback> positionCallback, PassOwnPtr<PositionErrorCallback> positionErrorCallback, PositionOptions* options)
     {
         return new GeoNotifier(geolocation, positionCallback, positionErrorCallback, options);
     }
     void trace(Visitor*);
 
@@ skipping 28 matching lines @@
     OwnPtr<PositionErrorCallback> m_errorCallback;
     Member<PositionOptions> m_options;
     Timer<GeoNotifier> m_timer;
     Member<PositionError> m_fatalError;
     bool m_useCachedPosition;
 };
 
 } // namespace WebCore
 
 #endif // GeoNotifier_h