Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: extensions/renderer/module_system_test.h

Issue 402553002: Don't create a gin::IsolateHolder in extensions unittests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/renderer/module_system_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/module_system_test.h
diff --git a/extensions/renderer/module_system_test.h b/extensions/renderer/module_system_test.h
index 892159990d39742f94de97d21881b5065e7649f3..e72b25aff16f6955c5746f10b1db383a9755da56 100644
--- a/extensions/renderer/module_system_test.h
+++ b/extensions/renderer/module_system_test.h
@@ -9,7 +9,6 @@
#include "extensions/renderer/scoped_persistent.h"
#include "extensions/renderer/script_context.h"
#include "gin/public/context_holder.h"
-#include "gin/public/isolate_holder.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "v8/include/v8.h"
@@ -20,7 +19,7 @@ class ModuleSystemTestEnvironment {
class AssertNatives;
class StringSourceMap;
- explicit ModuleSystemTestEnvironment(gin::IsolateHolder* isolate_holder);
+ explicit ModuleSystemTestEnvironment(v8::Isolate* isolate);
~ModuleSystemTestEnvironment();
// Register a named JS module in the module system.
@@ -50,12 +49,12 @@ class ModuleSystemTestEnvironment {
ScriptContext* context() { return context_.get(); }
- v8::Isolate* isolate() { return isolate_holder_->isolate(); }
+ v8::Isolate* isolate() { return isolate_; }
AssertNatives* assert_natives() { return assert_natives_; }
private:
- gin::IsolateHolder* isolate_holder_;
+ v8::Isolate* isolate_;
scoped_ptr<gin::ContextHolder> context_holder_;
v8::HandleScope handle_scope_;
scoped_ptr<ScriptContext> context_;
@@ -98,7 +97,7 @@ class ModuleSystemTest : public testing::Test {
void RunResolvedPromises();
private:
- gin::IsolateHolder isolate_holder_;
+ v8::Isolate* isolate_;
scoped_ptr<ModuleSystemTestEnvironment> env_;
bool should_assertions_be_made_;
« no previous file with comments | « no previous file | extensions/renderer/module_system_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698