Issue 402553002: Don't create a gin::IsolateHolder in extensions unittests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 402553002: Don't create a gin::IsolateHolder in extensions unittests. (Closed)

Created:
6 years, 5 months ago by Sam McNally

Modified:
6 years, 5 months ago

Reviewers:
not at google - send to devlin

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Don't create a gin::IsolateHolder in extensions unittests. This isn't necessary because the test environment set up includes Blink creating an isolate holder. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283904

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -23 lines)			Patch
M	extensions/renderer/module_system_test.h	View	4 chunks	+4 lines, -5 lines	0 comments	Download
M	extensions/renderer/module_system_test.cc	View	4 chunks	+13 lines, -16 lines	0 comments	Download
M	extensions/renderer/script_context_set_unittest.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sammc@chromium.org/402553002/20001

6 years, 5 months ago (2014-07-17 21:29:27 UTC) #4

Message was sent while issue was closed.

Change committed as 283904