Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3555)

Unified Diff: build/android/buildbot/bb_device_steps.py

Issue 40253002: android: Run upload results script from the parent of src/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/buildbot/bb_device_steps.py
diff --git a/build/android/buildbot/bb_device_steps.py b/build/android/buildbot/bb_device_steps.py
index f3b0402e0375b7bca3073736a9a0d7853a0b7936..9738361b98b67d67a1b0506e23a5175fe4b85df9 100755
--- a/build/android/buildbot/bb_device_steps.py
+++ b/build/android/buildbot/bb_device_steps.py
@@ -24,6 +24,7 @@ from pylib import constants
from pylib.gtest import gtest_config
CHROME_SRC_DIR = bb_utils.CHROME_SRC
+DIR_BUILD_ROOT = os.path.dirname(CHROME_SRC_DIR)
CHROME_OUT_DIR = bb_utils.CHROME_OUT_DIR
sys.path.append(os.path.join(
CHROME_SRC_DIR, 'third_party', 'android_testrunner'))
@@ -48,6 +49,10 @@ I_TEST = collections.namedtuple('InstrumentationTest', [
'annotation', 'exclude_annotation', 'extra_flags'])
+def SrcPath(*path):
+ return os.path.join(CHROME_SRC_DIR, *path)
+
+
def I(name, apk, apk_package, test_apk, test_data, host_driven_root=None,
annotation=None, exclude_annotation=None, extra_flags=None):
return I_TEST(name, apk, apk_package, test_apk, test_data, host_driven_root,
@@ -221,7 +226,7 @@ def RunInstrumentationSuite(options, test, flunk_on_failure=True,
def RunWebkitLint(target):
"""Lint WebKit's TestExpectation files."""
bb_annotations.PrintNamedStep('webkit_lint')
- RunCmd(['webkit/tools/layout_tests/run_webkit_tests.py',
+ RunCmd([SrcPath('webkit/tools/layout_tests/run_webkit_tests.py'),
'--lint-test-files',
'--chromium',
'--target', target])
@@ -261,8 +266,8 @@ def RunWebkitLayoutTests(options):
cmd_args.extend(
['--additional-expectations=%s' % os.path.join(CHROME_SRC_DIR, *f)])
- exit_code = RunCmd(['webkit/tools/layout_tests/run_webkit_tests.py'] +
- cmd_args)
+ exit_code = RunCmd([SrcPath('webkit/tools/layout_tests/run_webkit_tests.py')]
+ + cmd_args)
if exit_code == 255: # test_run_results.UNEXPECTED_ERROR_EXIT_STATUS
bb_annotations.PrintMsg('?? (crashed or hung)')
elif exit_code == 254: # test_run_results.NO_DEVICES_EXIT_STATUS
@@ -310,7 +315,8 @@ def RunWebkitLayoutTests(options):
'--build-dir', CHROME_OUT_DIR,
'--build-number', build_number,
'--builder-name', builder_name,
- '--gs-bucket', gs_bucket])
+ '--gs-bucket', gs_bucket],
+ cwd=DIR_BUILD_ROOT)
def _ParseLayoutTestResults(results):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698