Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Issue 402503003: Add more Windows-specific fonts to fallback path (Closed)

Created:
6 years, 5 months ago by scottmg
Modified:
6 years, 5 months ago
Reviewers:
eae
CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Add more Windows-specific fonts to fallback path MS Shell Dlg is the aliased font name that means "the one font that shall always be available" per http://msdn.microsoft.com/en-us/library/windows/desktop/dd374112(v=vs.85).aspx DirectWrite doesn't like that name, but we add the two fonts that it can map to so that we can be very certain to succeed on retreiving a font, even if Arial has gone missing. R=eae@chromium.org BUG=383542 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178380

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M Source/platform/fonts/skia/FontCacheSkia.cpp View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scottmg
6 years, 5 months ago (2014-07-17 04:46:32 UTC) #1
eae
LGTM
6 years, 5 months ago (2014-07-17 15:09:46 UTC) #2
eae
The CQ bit was checked by eae@chromium.org
6 years, 5 months ago (2014-07-17 15:09:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/402503003/1
6 years, 5 months ago (2014-07-17 15:10:06 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 16:19:31 UTC) #5
Message was sent while issue was closed.
Change committed as 178380

Powered by Google App Engine
This is Rietveld 408576698