Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 402463002: Replace agg with skia (Closed)

Created:
6 years, 5 months ago by Bo Xu
Modified:
5 years, 7 months ago
Reviewers:
jam, reed2, caryclark, reed1
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Visibility:
Public.

Description

Replace agg with skia BUG=None

Patch Set 1 #

Patch Set 2 : Correct gyp and gn #

Patch Set 3 : Fix BUILD.gn syntax #

Patch Set 4 : Fix clang compile error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2621 lines, -9318 lines) Patch
M BUILD.gn View 1 2 3 5 chunks +3 lines, -40 lines 0 comments Download
M core/include/fxge/fx_ge.h View 2 chunks +2 lines, -17 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render.cpp View 1 chunk +1 line, -1 line 0 comments Download
D core/src/fxge/agg/agg23/agg_array.h View 1 chunk +0 lines, -510 lines 0 comments Download
D core/src/fxge/agg/agg23/agg_basics.h View 1 chunk +0 lines, -282 lines 0 comments Download
D core/src/fxge/agg/agg23/agg_clip_liang_barsky.h View 1 chunk +0 lines, -125 lines 0 comments Download
D core/src/fxge/agg/agg23/agg_color_gray.h View 1 chunk +0 lines, -50 lines 0 comments Download
D core/src/fxge/agg/agg23/agg_conv_adaptor_vcgen.h View 1 chunk +0 lines, -138 lines 0 comments Download
D core/src/fxge/agg/agg23/agg_conv_dash.h View 1 chunk +0 lines, -61 lines 0 comments Download
D core/src/fxge/agg/agg23/agg_conv_stroke.h View 1 chunk +0 lines, -110 lines 0 comments Download
D core/src/fxge/agg/agg23/agg_curves.h View 1 chunk +0 lines, -191 lines 0 comments Download
D core/src/fxge/agg/agg23/agg_math.h View 1 chunk +0 lines, -63 lines 0 comments Download
D core/src/fxge/agg/agg23/agg_math_stroke.h View 1 chunk +0 lines, -272 lines 0 comments Download
D core/src/fxge/agg/agg23/agg_path_storage.h View 1 chunk +0 lines, -172 lines 0 comments Download
D core/src/fxge/agg/agg23/agg_pixfmt_gray.h View 1 chunk +0 lines, -177 lines 0 comments Download
D core/src/fxge/agg/agg23/agg_rasterizer_scanline_aa.h View 1 chunk +0 lines, -472 lines 0 comments Download
D core/src/fxge/agg/agg23/agg_render_scanlines.h View 1 chunk +0 lines, -50 lines 0 comments Download
D core/src/fxge/agg/agg23/agg_renderer_base.h View 1 chunk +0 lines, -163 lines 0 comments Download
D core/src/fxge/agg/agg23/agg_renderer_scanline.h View 1 chunk +0 lines, -93 lines 0 comments Download
D core/src/fxge/agg/agg23/agg_rendering_buffer.h View 1 chunk +0 lines, -145 lines 0 comments Download
D core/src/fxge/agg/agg23/agg_scanline_u.h View 1 chunk +0 lines, -150 lines 0 comments Download
D core/src/fxge/agg/agg23/agg_shorten_path.h View 1 chunk +0 lines, -57 lines 0 comments Download
D core/src/fxge/agg/agg23/agg_vcgen_dash.h View 1 chunk +0 lines, -75 lines 0 comments Download
D core/src/fxge/agg/agg23/agg_vcgen_stroke.h View 1 chunk +0 lines, -120 lines 0 comments Download
D core/src/fxge/agg/agg23/agg_vertex_sequence.h View 1 chunk +0 lines, -100 lines 0 comments Download
D core/src/fxge/agg/agg23/fx_agg_curves.cpp View 1 chunk +0 lines, -109 lines 0 comments Download
D core/src/fxge/agg/agg23/fx_agg_driver.cpp View 1 chunk +0 lines, -1633 lines 0 comments Download
D core/src/fxge/agg/agg23/fx_agg_path_storage.cpp View 1 chunk +0 lines, -104 lines 0 comments Download
D core/src/fxge/agg/agg23/fx_agg_rasterizer_scanline_aa.cpp View 1 chunk +0 lines, -495 lines 0 comments Download
D core/src/fxge/agg/agg23/fx_agg_vcgen_dash.cpp View 1 chunk +0 lines, -176 lines 0 comments Download
D core/src/fxge/agg/agg23/fx_agg_vcgen_stroke.cpp View 1 chunk +0 lines, -214 lines 0 comments Download
D core/src/fxge/agg/include/fx_agg_driver.h View 1 chunk +0 lines, -121 lines 0 comments Download
D core/src/fxge/agg/include/fxfx_agg_basics.h View 1 chunk +0 lines, -10 lines 0 comments Download
D core/src/fxge/agg/include/fxfx_agg_clip_liang_barsky.h View 1 chunk +0 lines, -10 lines 0 comments Download
D core/src/fxge/agg/include/fxfx_agg_conv_dash.h View 1 chunk +0 lines, -10 lines 0 comments Download
D core/src/fxge/agg/include/fxfx_agg_conv_stroke.h View 1 chunk +0 lines, -10 lines 0 comments Download
D core/src/fxge/agg/include/fxfx_agg_curves.h View 1 chunk +0 lines, -10 lines 0 comments Download
D core/src/fxge/agg/include/fxfx_agg_path_storage.h View 1 chunk +0 lines, -10 lines 0 comments Download
D core/src/fxge/agg/include/fxfx_agg_rasterizer_scanline_aa.h View 1 chunk +0 lines, -10 lines 0 comments Download
D core/src/fxge/agg/include/fxfx_agg_renderer_scanline.h View 1 chunk +0 lines, -10 lines 0 comments Download
D core/src/fxge/agg/include/fxfx_agg_rendering_buffer.h View 1 chunk +0 lines, -10 lines 0 comments Download
D core/src/fxge/agg/include/fxfx_agg_scanline_u.h View 1 chunk +0 lines, -10 lines 0 comments Download
D core/src/fxge/agg/src/fxfx_agg_curves.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
D core/src/fxge/agg/src/fxfx_agg_driver.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
D core/src/fxge/agg/src/fxfx_agg_path_storage.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
D core/src/fxge/agg/src/fxfx_agg_rasterizer_scanline_aa.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
D core/src/fxge/agg/src/fxfx_agg_vcgen_dash.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
D core/src/fxge/agg/src/fxfx_agg_vcgen_stroke.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M core/src/fxge/android/fpf_skiamodule.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/android/fx_android_imp.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fxge/apple/apple_int.h View 1 chunk +11 lines, -0 lines 0 comments Download
M core/src/fxge/apple/fx_apple_platform.cpp View 3 chunks +2 lines, -78 lines 0 comments Download
M core/src/fxge/apple/fx_quartz_device.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M core/src/fxge/ge/fx_ge_device.cpp View 2 chunks +46 lines, -0 lines 0 comments Download
M core/src/fxge/ge/fx_ge_linux.cpp View 1 chunk +1 line, -26 lines 0 comments Download
A + core/src/fxge/skia/fx_skia.h View 1 chunk +11 lines, -7 lines 0 comments Download
A core/src/fxge/skia/fx_skia_blitter.h View 1 chunk +201 lines, -0 lines 0 comments Download
A core/src/fxge/skia/fx_skia_blitter.cpp View 1 2 3 1 chunk +1182 lines, -0 lines 0 comments Download
D core/src/fxge/skia/fx_skia_blitter_new.h View 1 chunk +0 lines, -229 lines 0 comments Download
D core/src/fxge/skia/fx_skia_blitter_new.cpp View 1 chunk +0 lines, -1610 lines 0 comments Download
D core/src/fxge/skia/fx_skia_device.h View 1 chunk +0 lines, -90 lines 0 comments Download
D core/src/fxge/skia/fx_skia_device.cpp View 1 chunk +0 lines, -531 lines 0 comments Download
A core/src/fxge/skia/fx_skia_driver.h View 1 2 3 1 chunk +147 lines, -0 lines 0 comments Download
A core/src/fxge/skia/fx_skia_driver.cpp View 1 2 3 1 chunk +971 lines, -0 lines 0 comments Download
A + core/src/fxge/win32/agg_clip_liang_barsky.h View 6 chunks +30 lines, -41 lines 0 comments Download
M core/src/fxge/win32/fx_win32_device.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/fpdf_progressive.cpp View 1 chunk +1 line, -8 lines 0 comments Download
M fpdfsdk/src/fpdfformfill.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M fpdfsdk/src/fpdfview.cpp View 3 chunks +1 line, -17 lines 0 comments Download
M pdfium.gyp View 1 2 3 5 chunks +5 lines, -42 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bo Xu
Hi John, please review the changes of skia and agg. Right now the code compiles ...
6 years, 5 months ago (2014-07-16 23:08:17 UTC) #1
reed1
6 years, 5 months ago (2014-07-17 12:15:24 UTC) #2
Bo Xu
6 years, 5 months ago (2014-07-18 17:19:36 UTC) #3 
On 2014/07/17 12:15:24, reed1 wrote:

Hi reed, any comments?

Powered by Google App Engine
This is Rietveld 408576698