Expose the content of Sets and WeakSets through SetMirror.

src/mirror-debugger.js

 // Copyright 2006-2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Handle id counters.
 var next_handle_ = 0;
 var next_transient_handle_ = -1;
 
 // Mirror cache.
 var mirror_cache_ = [];
@@ skipping 65 matching lines @@
   } else if (IS_FUNCTION(value)) {
     mirror = new FunctionMirror(value);
   } else if (IS_REGEXP(value)) {
     mirror = new RegExpMirror(value);
   } else if (IS_ERROR(value)) {
     mirror = new ErrorMirror(value);
   } else if (IS_SCRIPT(value)) {
     mirror = new ScriptMirror(value);
   } else if (IS_MAP(value) || IS_WEAKMAP(value)) {
     mirror = new MapMirror(value);
+  } else if (IS_SET(value) || IS_WEAKSET(value)) {
+    mirror = new SetMirror(value);
   } else if (ObjectIsPromise(value)) {
     mirror = new PromiseMirror(value);
   } else {
     mirror = new ObjectMirror(value, OBJECT_TYPE, opt_transient);
   }
 
   if (mirror_cache_enabled_) mirror_cache_[mirror.handle()] = mirror;
   return mirror;
 }
 
@@ skipping 55 matching lines @@
 var REGEXP_TYPE = 'regexp';
 var ERROR_TYPE = 'error';
 var PROPERTY_TYPE = 'property';
 var INTERNAL_PROPERTY_TYPE = 'internalProperty';
 var FRAME_TYPE = 'frame';
 var SCRIPT_TYPE = 'script';
 var CONTEXT_TYPE = 'context';
 var SCOPE_TYPE = 'scope';
 var PROMISE_TYPE = 'promise';
 var MAP_TYPE = 'map';
+var SET_TYPE = 'set';
 
 // Maximum length when sending strings through the JSON protocol.
 var kMaxProtocolStringLength = 80;
 
 // Different kind of properties.
 var PropertyKind = {};
 PropertyKind.Named   = 1;
 PropertyKind.Indexed = 2;
 
 
@@ skipping 36 matching lines @@
 //       - SymbolMirror
 //       - ObjectMirror
 //         - FunctionMirror
 //           - UnresolvedFunctionMirror
 //         - ArrayMirror
 //         - DateMirror
 //         - RegExpMirror
 //         - ErrorMirror
 //         - PromiseMirror
 //         - MapMirror
+//         - SetMirror
 //     - PropertyMirror
 //     - InternalPropertyMirror
 //     - FrameMirror
 //     - ScriptMirror
 
 
 /**
  * Base class for all mirror objects.
  * @param {string} type The type of the mirror
  * @constructor
@@ skipping 200 matching lines @@
 /**
  * Check whether the mirror reflects a map.
  * @returns {boolean} True if the mirror reflects a map
  */
 Mirror.prototype.isMap = function() {
   return this instanceof MapMirror;
 };
 
 
 /**
+ * Check whether the mirror reflects a set.
+ * @returns {boolean} True if the mirror reflects a set
+ */
+Mirror.prototype.isSet = function() {
+  return this instanceof SetMirror;
+};
+
+
+/**
  * Allocate a handle id for this object.
  */
 Mirror.prototype.allocateHandle_ = function() {
   if (mirror_cache_enabled_) this.handle_ = next_handle_++;
 };
 
 
 /**
  * Allocate a transient handle id for this object. Transient handles are
  * negative.
@@ skipping 850 matching lines @@
   while (!(next = iter.next()).done) {
     result.push({
       key: next.value[0],
       value: next.value[1]
     });
   }
   return result;
 };
 
 
+function SetMirror(value) {
+  %_CallFunction(this, value, SET_TYPE, ObjectMirror);
+}
+inherits(SetMirror, ObjectMirror);
+
+
+/**
+ * Returns an array of elements of a set.
+ * This will keep elements alive for WeakSets.
+ *
+ * @returns {Array.<Object>} Array of elements of a set.
+ */
+SetMirror.prototype.entries = function() {
+  if (IS_WEAKSET(this.value_)) {
+    return %GetWeakSetEntries(this.value_);
+  }
+
+  var result = [];
+  var iter = %_CallFunction(this.value_, builtins.SetEntries);

[arv (Not doing code reviews), 2014/07/22 15:15:10]

You can do SetValues here instead. No need for the extra array allocation here.

[Alexandra Mikhaylova, 2014/07/22 16:01:18]

Thanks, fixed it.

+  var next;
+  while (!(next = iter.next()).done) {
+    result.push(next.value[0]);
+  }
+  return result;
+};
+
+
 /**
  * Base mirror object for properties.
  * @param {ObjectMirror} mirror The mirror object having this property
  * @param {string} name The name of the property
  * @param {Array} details Details about the property
  * @constructor
  * @extends Mirror
  */
 function PropertyMirror(mirror, name, details) {
   %_CallFunction(this, PROPERTY_TYPE, Mirror);
@@ skipping 1512 matching lines @@
   }
   if (!NUMBER_IS_FINITE(value)) {
     if (value > 0) {
       return 'Infinity';
     } else {
       return '-Infinity';
     }
   }
   return value;
 }