Expose the content of Sets and WeakSets through SetMirror.

Expose the content of Sets and WeakSets through SetMirror.

BUG=v8:3093
LOG=Y
R=aandrey@chromium.org, arv@chromium.org, yangguo@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=22541

[aandrey, 2014-07-22 13:02:18]

lgtm

[arv (Not doing code reviews), 2014-07-22 15:15:10]

https://codereview.chromium.org/402423003/diff/1/src/mirror-debugger.js
File src/mirror-debugger.js (right):

https://codereview.chromium.org/402423003/diff/1/src/mirror-debugger.js#newco...
src/mirror-debugger.js:1338: var iter = %_CallFunction(this.value_,
builtins.SetEntries);
You can do SetValues here instead. No need for the extra array allocation here.

https://codereview.chromium.org/402423003/diff/1/src/runtime.cc
File src/runtime.cc (right):

https://codereview.chromium.org/402423003/diff/1/src/runtime.cc#newcode1801
src/runtime.cc:1801: RUNTIME_FUNCTION(Runtime_GetWeakSetEntries) {
-> GetWeakSetValues

https://codereview.chromium.org/402423003/diff/1/src/runtime.cc#newcode1806
src/runtime.cc:1806: Handle<FixedArray> entries =
entries is misleading since you are not return an array of pairs here.

[Alexandra Mikhaylova, 2014-07-22 16:01:18]

https://codereview.chromium.org/402423003/diff/1/src/mirror-debugger.js
File src/mirror-debugger.js (right):

https://codereview.chromium.org/402423003/diff/1/src/mirror-debugger.js#newco...
src/mirror-debugger.js:1338: var iter = %_CallFunction(this.value_,
builtins.SetEntries);
On 2014/07/22 15:15:10, arv wrote:
> You can do SetValues here instead. No need for the extra array allocation
here.

Thanks, fixed it.

https://codereview.chromium.org/402423003/diff/1/src/runtime.cc
File src/runtime.cc (right):

https://codereview.chromium.org/402423003/diff/1/src/runtime.cc#newcode1801
src/runtime.cc:1801: RUNTIME_FUNCTION(Runtime_GetWeakSetEntries) {
On 2014/07/22 15:15:10, arv wrote:
> -> GetWeakSetValues

Done, also renamed SetMirror.prototype.entries -> SetMirror.prototype.values.

https://codereview.chromium.org/402423003/diff/1/src/runtime.cc#newcode1806
src/runtime.cc:1806: Handle<FixedArray> entries =
On 2014/07/22 15:15:10, arv wrote:
> entries is misleading since you are not return an array of pairs here.

Fixed.

[arv (Not doing code reviews), 2014-07-22 16:53:18]

LGTM

[Yang, 2014-07-23 07:16:01]

On 2014/07/22 16:53:18, arv wrote:
> LGTM

LGTM.

[Yang, 2014-07-23 07:33:56]

Committed patchset #2 manually as r22541 (presubmit successful).