Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 402423002: Update WebFrameTestProxy to use chromium naming conventions. (Closed)

Created:
6 years, 5 months ago by dcheng
Modified:
6 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Update WebFrameTestProxy to use chromium naming conventions. more_underscores, lessCamelCase. BUG=360024 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284811

Patch Set 1 #

Patch Set 2 : Oops #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -49 lines) Patch
M content/shell/renderer/test_runner/web_frame_test_proxy.h View 1 2 11 chunks +60 lines, -49 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
dcheng
Sorry for the delay.
6 years, 5 months ago (2014-07-22 07:03:36 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-22 07:27:46 UTC) #2
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 5 months ago (2014-07-22 07:29:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/402423002/20001
6 years, 5 months ago (2014-07-22 07:30:32 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-22 11:14:59 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 12:17:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/33028)
6 years, 5 months ago (2014-07-22 12:17:30 UTC) #7
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 5 months ago (2014-07-22 18:20:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/402423002/20001
6 years, 5 months ago (2014-07-22 18:21:47 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-22 18:31:09 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 18:43:29 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/33158)
6 years, 5 months ago (2014-07-22 18:43:30 UTC) #12
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 5 months ago (2014-07-22 21:05:29 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/402423002/30001
6 years, 5 months ago (2014-07-22 21:07:23 UTC) #14
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 23:44:17 UTC) #15
Message was sent while issue was closed. 
Change committed as 284811

Powered by Google App Engine
This is Rietveld 408576698