Move common account picker/user pod js/css/html out of src/chrome

Move common account picker/user pod js/css/html out of src/chrome.

This CL only moves account picker related resources that are used on Chrome OS (login UI) and Chrome Win/Mac/Linux (user_manager UI).

The rest of Chrome OS out-of-box/login WebUI resources will be moved later as well.

BUG=387608, 370175
R=dzhioev@chromium.org, sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285523

[Nikita (slow), 2014-07-22 14:34:59]

+sky for OWNERS review of chrome/browser/browser_resources.grd
and general idea of moving common login UI code out of src/chrome.

[Nikita (slow), 2014-07-22 14:37:42]

+Monica, should not break user_manager.

[sky, 2014-07-22 18:02:48]

+ben for his thoughts on whether this should live in ui or something like
components/

Won't there be common login/authentication code as well? Where will that live?
Also, don't forget to add DEPS for your new directory.

[Nikita (slow), 2014-07-23 08:38:36]

On 2014/07/22 18:02:48, sky wrote:
> +ben for his thoughts on whether this should live in ui or something like
> components/

I think at this point this part of code is not ready to live in components/ yet
since these js/css/html files are included by others in 
chrome/browser/resources/user_manager/* and
chrome/browser/resources/chromeos/login/*

> 
> Won't there be common login/authentication code as well? Where will that live?

I was planning to have ui part of it (js/css/html) in ui/login but login
handlers etc. maybe in components/login or as well in ui/login.

Other parts:
Chrome OS auth stack will be part of chromeos/login (cryptohome related).
user management: components/user_manager
session management: components/session_manager

> Also, don't forget to add DEPS for your new directory.

[Nikita (slow), 2014-07-23 08:39:23]

On 2014/07/22 18:02:48, sky wrote:
> Also, don't forget to add DEPS for your new directory.

At this point it only contains js/css/html resources so I think DEPS is not
needed.
Are you suggesting creating empty DEPS file for now?

[Ben Goodger (Google), 2014-07-23 16:26:56]

ui is probably fine for now since we have ui/keyboard also. i agree at some
point it'd be nice to have a clearer separation between framework and apps
but we don't have a great solution now.

-Ben


On Tue, Jul 22, 2014 at 11:02 AM, <sky@chromium.org> wrote:

> +ben for his thoughts on whether this should live in ui or something like
> components/
>
> Won't there be common login/authentication code as well? Where will that
> live?
> Also, don't forget to add DEPS for your new directory.
>
> https://codereview.chromium.org/402403005/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[sky, 2014-07-23 17:05:50]

On Wed, Jul 23, 2014 at 1:39 AM,  <nkostylev@chromium.org> wrote:
> On 2014/07/22 18:02:48, sky wrote:
>>
>> Also, don't forget to add DEPS for your new directory.
>
>
> At this point it only contains js/css/html resources so I think DEPS is not
> needed.
> Are you suggesting creating empty DEPS file for now?

Yes. Just to make sure nothing new is introduced.
>
> https://codereview.chromium.org/402403005/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[sky, 2014-07-23 17:07:55]

https://codereview.chromium.org/402403005/diff/20042/chrome/browser/resources...
File chrome/browser/resources/chromeos/login/login_screens.html (right):

https://codereview.chromium.org/402403005/diff/20042/chrome/browser/resources...
chrome/browser/resources/chromeos/login/login_screens.html:6: <include
src="../../../../../ui/login/account_picker/screen_account_picker.html">
Relative paths like this are awful. Is there no better way?

[Nikita (slow), 2014-07-24 08:27:53]

On 2014/07/23 17:07:55, sky wrote:
>
https://codereview.chromium.org/402403005/diff/20042/chrome/browser/resources...
> File chrome/browser/resources/chromeos/login/login_screens.html (right):
> 
>
https://codereview.chromium.org/402403005/diff/20042/chrome/browser/resources...
> chrome/browser/resources/chromeos/login/login_screens.html:6: <include
> src="../../../../../ui/login/account_picker/screen_account_picker.html">
> Relative paths like this are awful. Is there no better way?

Since these are included during resource pak creation time I don't think there's
a better way to handle at this point.

[sky, 2014-07-24 16:58:36]

Ok, LGTM

[dzhioev (left Google), 2014-07-24 17:12:47]

I can't see any advantages in putting files into separate directories based on
their extension. Can we put them together as it was before?

[Nikita (slow), 2014-07-24 17:49:53]

On 2014/07/24 17:12:47, dzhioev wrote:
> I can't see any advantages in putting files into separate directories based on
> their extension. Can we put them together as it was before?

Done.

[dzhioev (left Google), 2014-07-24 19:36:17]

On 2014/07/24 17:49:53, Nikita Kostylev wrote:
> On 2014/07/24 17:12:47, dzhioev wrote:
> > I can't see any advantages in putting files into separate directories based
on
> > their extension. Can we put them together as it was before?
> 
> Done.

LGTM

[Nikita (slow), 2014-07-24 20:39:28]

The CQ bit was checked by nkostylev@chromium.org

[commit-bot: I haz the power, 2014-07-24 20:41:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/nkostylev@chromium.org/402403005/40001

[commit-bot: I haz the power, 2014-07-25 01:45:40]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-25 02:29:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-25 02:29:52]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[Nikita (slow), 2014-07-25 07:42:56]

Committed patchset #4 manually as r285523.