Added code to fix visibility of select all option in context menu.

Source/web/ContextMenuClientImpl.cpp

 /*
  * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 202 matching lines @@
         data.editFlags |= WebContextMenuData::CanRedo;
     if (toLocalFrame(m_webView->focusedWebCoreFrame())->editor().canCut())
         data.editFlags |= WebContextMenuData::CanCut;
     if (toLocalFrame(m_webView->focusedWebCoreFrame())->editor().canCopy())
         data.editFlags |= WebContextMenuData::CanCopy;
     if (toLocalFrame(m_webView->focusedWebCoreFrame())->editor().canPaste())
         data.editFlags |= WebContextMenuData::CanPaste;
     if (toLocalFrame(m_webView->focusedWebCoreFrame())->editor().canDelete())
         data.editFlags |= WebContextMenuData::CanDelete;
     // We can always select all...
-    data.editFlags |= WebContextMenuData::CanSelectAll;
+    Node* node = r.innerNonSharedNode();
+    int len = 0;
+    if (node->isElementNode() && (static_cast<Element *>(node))->isFormControlElement()) {

[darin (slow to review), 2014/07/25 05:11:56]

nit: no " " before "*"

+        Element* element  = toHTMLFormControlElement(node);
+        if (element->isTextFormControl())
+            len = (static_cast<HTMLTextFormControlElement *>(element))->value().length();

[darin (slow to review), 2014/07/25 05:11:56]

I would probably skip the "len" local variable and just check the result of
.isEmpty(). You can modify editFlags in this scope.

+    }
+    if (len > 0)
+        data.editFlags |= WebContextMenuData::CanSelectAll;
     data.editFlags |= WebContextMenuData::CanTranslate;
 
     // Links, Images, Media tags, and Image/Media-Links take preference over
     // all else.
     data.linkURL = r.absoluteLinkURL();
 
     if (isHTMLCanvasElement(r.innerNonSharedNode())) {
         data.mediaType = WebContextMenuData::MediaTypeCanvas;
         data.hasImageContents = true;
     } else if (!r.absoluteImageURL().isEmpty()) {
@@ skipping 203 matching lines @@
         outputItems[i] = subItems[i];
     subMenuItems.swap(outputItems);
 }
 
 void ContextMenuClientImpl::populateCustomMenuItems(const blink::ContextMenu* defaultMenu, WebContextMenuData* data)
 {
     populateSubMenuItems(defaultMenu->items(), data->customItems);
 }
 
 } // namespace blink