Implementation of the 'edit.getFixes' API in server.

pkg/analysis_server/lib/src/analysis_server.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analysis.server;
 
 import 'dart:async';
 import 'dart:collection';
 
 import 'package:analyzer/file_system/file_system.dart';
@@ skipping 537 matching lines @@
     // if library has not been resolved yet, the unit will be resolved later
     Source librarySource = librarySources[0];
     if (context.getLibraryElement(librarySource) == null) {
       return null;
     }
     // if library has been already resolved, resolve unit
     return context.resolveCompilationUnit2(unitSource, librarySource);
   }
 
   /**
+   * Returns all the [AnalysisErrorInfo] for [file].
+   *
+   * May return `null`.
+   */
+  AnalysisErrorInfo getErrors(String file) {
+    // prepare AnalysisContext
+    AnalysisContext context = getAnalysisContext(file);
+    if (context == null) {
+      return null;

[Paul Berry, 2014/07/22 20:22:06]

Does this mean that the result will be {..., "result": {"errors": null}} in the
case where there was no analysis context?  That's not allowed according to the
spec; probably we should report an error in this condition.

[scheglov, 2014/07/22 20:31:31]

It is OK for "edit.getFixes" though.

[Paul Berry, 2014/07/22 20:41:43]

Oh, ok.  I was confused because the method name sounds like it corresponds to
the "analysis.getErrors" request.  Can you include a comment above the function
to clarify that it's intended for use by "getFixes", and hence doesn't have to
wait for errors to be computed?

[scheglov, 2014/07/22 20:53:08]

Done.

+    }
+    // get errors for the file
+    Source source = getSource(file);
+    return context.getErrors(source);

[Paul Berry, 2014/07/22 20:22:06]

Judging from the implementation in AnalysisContextImpl, it looks like this just
gets the currently computed set of errors; it doesn't wait for the errors to be
computed.  According to the spec (and the IntelliJ requirements that motivated
this feature) the server needs to wait until errors have been fully computed
before a response is returned.

[scheglov, 2014/07/22 20:31:31]

It's not an implementation of the "analysis.getErrors" API.
This methods returns just the currently computed set of errors, as needed for
"edit.getFixes".

An implementation of "analysis.getErrors" is in my queue, blocked by this
AnalysisError value object change.

+  }
+
+  /**
    * Returns resolved [CompilationUnit]s of the Dart file with the given [path].
    *
    * May be empty, but not `null`.
    */
   List<CompilationUnit> getResolvedCompilationUnits(String path) {
     List<CompilationUnit> units = <CompilationUnit>[];
     // prepare AnalysisContext
     AnalysisContext context = getAnalysisContext(path);
     if (context == null) {
       return units;
@@ skipping 89 matching lines @@
 /**
  * An enumeration of the services provided by the server domain.
  */
 class ServerService extends Enum2<ServerService> {
   static const ServerService STATUS = const ServerService('STATUS', 0);
 
   static const List<ServerService> VALUES = const [STATUS];
 
   const ServerService(String name, int ordinal) : super(name, ordinal);
 }