Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: src/d8.cc

Issue 40233002: Avoid calling OS::TotalPhysicalMemory in defaults.cc, since this fails in the chrome renderer sandb… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/d8.cc
diff --git a/src/d8.cc b/src/d8.cc
index 96407a897c98b1284a3f9b1dd78bb457c5b08bd7..818c7e9097558f2a9142ecfe6ea8f3404e6a2372 100644
--- a/src/d8.cc
+++ b/src/d8.cc
@@ -1660,7 +1660,8 @@ int Shell::Main(int argc, char* argv[]) {
#else
SetStandaloneFlagsViaCommandLine();
#endif
- v8::SetDefaultResourceConstraintsForCurrentPlatform();
+ v8::InitializeDefaultsForCurrentPlatform(i::OS::TotalPhysicalMemory());
+ ASSERT(v8::SetDefaultResourceConstraintsForCurrentPlatform());
Sven Panne 2013/10/25 06:27:16 Huh? A side effect in an assert? This is definitel
ShellArrayBufferAllocator array_buffer_allocator;
v8::V8::SetArrayBufferAllocator(&array_buffer_allocator);
int result = 0;

Powered by Google App Engine
This is Rietveld 408576698