Issue 40233: Add a product_name of 'chrome' on the non-Mac systems so they can...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 40233: Add a product_name of 'chrome' on the non-Mac systems so they can... (Closed)

Created:
11 years, 9 months ago by sgk

Modified:
9 years, 5 months ago

Reviewers:
Mark Mentovai, bradn

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add a product_name of 'chrome' on the non-Mac systems. This adds a placeholder condition for building branded 'chrome.exe' vs. 'chromium.exe', which can be updated to build 'chromium.exe' by default whenever we update the infrastructure (buildbots, developer instructions, etc.) to use -Dbranding=Chrome. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11150

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	M	chrome/chrome.gyp	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages