Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 402323002: Revert of mac: [Yosemite] Fix bug where zoom button causes fullscreen mode. (Closed)

Created:
6 years, 5 months ago by Kunihiko Sakamoto
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of mac: [Yosemite] Fix bug where zoom button causes fullscreen mode. (https://codereview.chromium.org/402443003/) Reason for revert: Broke Mac ASan 64 Builder http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Builder/builds/7520 obj/chrome/browser/ui/cocoa/browser_ui.version_independent_window.o ../../chrome/browser/ui/cocoa/version_independent_window.mm:109:44:error: cannot initialize a parameter of type 'NSComparisonResult (*)(id, id, void *)' with an rvalue of type 'int (*)(id, id, void *)': different return type ('NSComparisonResult' (aka 'long') vs 'int') [superview sortSubviewsUsingFunction:&ReorderContentViewToBack ^~~~~~~~~~~~~~~~~~~~~~~~~ /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSView.h:175:75: note: passing argument to parameter 'compare' here - (void)sortSubviewsUsingFunction:(NSComparisonResult (*)(id, id, void *))compare context:(void *)context; Original issue's description: > mac: [Yosemite] Fix bug where zoom button causes fullscreen mode. > > In Yosemite, holding down alt while clicking the fullscreen button is supposed > to zoom the window. This doesn't work because Chrome violates unstated AppKit > assumptions. > > The problem seems to lie in hit testing the location of the zoom button. > Reordering the subviews by moving the tab strip and the content view behind the > zoom button fixes the problem. > > BUG=393808 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284544 TBR=andresantoso@chromium.org,shess@chromium.org,erikchen@chromium.org NOTREECHECKS=true NOTRY=true BUG=393808 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284576

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -39 lines) Patch
M chrome/browser/ui/cocoa/version_independent_window.mm View 3 chunks +6 lines, -39 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Kunihiko Sakamoto
Created Revert of mac: [Yosemite] Fix bug where zoom button causes fullscreen mode.
6 years, 5 months ago (2014-07-22 00:46:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ksakamoto@chromium.org/402323002/1
6 years, 5 months ago (2014-07-22 00:51:50 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 01:05:03 UTC) #3
Message was sent while issue was closed.
Change committed as 284576

Powered by Google App Engine
This is Rietveld 408576698