Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 402303003: Enable the AllowSuperUnsafeScript assert disabler in debug builds. (Closed)

Created:
6 years, 5 months ago by esprehn
Modified:
6 years, 5 months ago
CC:
abarth-chromium, arv+blink, blink-reviews, blink-reviews-bindings_chromium.org
Project:
blink
Visibility:
Public.

Description

Enable the AllowSuperUnsafeScript assert disabler in debug builds. Don't crash debug builds when there's an AllowSuperUnsafeScript assert disabler in place. R=haraken@chromium.org,abarth@chromium.org BUG=395164 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178615

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M Source/platform/ScriptForbiddenScope.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/ScriptForbiddenScope.cpp View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
esprehn
6 years, 5 months ago (2014-07-22 01:05:26 UTC) #1
haraken
LGTM
6 years, 5 months ago (2014-07-22 01:08:02 UTC) #2
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 5 months ago (2014-07-22 01:12:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/402303003/20001
6 years, 5 months ago (2014-07-22 01:13:13 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 5 months ago (2014-07-22 02:17:13 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 03:09:03 UTC) #6
Message was sent while issue was closed.
Change committed as 178615

Powered by Google App Engine
This is Rietveld 408576698