Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1397)

Unified Diff: Source/core/rendering/compositing/CompositingReasonFinder.cpp

Issue 402283003: Fix bugs in clip parent calculations (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: . Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/compositing/CompositingInputsUpdater.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/compositing/CompositingReasonFinder.cpp
diff --git a/Source/core/rendering/compositing/CompositingReasonFinder.cpp b/Source/core/rendering/compositing/CompositingReasonFinder.cpp
index 6c2eaee85e8829f0ef180f7d8403fe924d938d42..4ecc89684ac1b529f7a32b93231d30a129faddde 100644
--- a/Source/core/rendering/compositing/CompositingReasonFinder.cpp
+++ b/Source/core/rendering/compositing/CompositingReasonFinder.cpp
@@ -154,14 +154,12 @@ CompositingReasons CompositingReasonFinder::nonStyleDeterminedDirectReasons(cons
RenderObject* renderer = layer->renderer();
if (hasOverflowScrollTrigger()) {
- if (const RenderLayer* scrollingAncestor = layer->ancestorScrollingLayer()) {
- if (scrollingAncestor->needsCompositedScrolling()) {
- if (layer->clipParent())
- directReasons |= CompositingReasonOutOfFlowClipping;
+ if (layer->clipParent())
+ directReasons |= CompositingReasonOutOfFlowClipping;
- if (layer->scrollParent())
- directReasons |= CompositingReasonOverflowScrollingParent;
- }
+ if (const RenderLayer* scrollingAncestor = layer->ancestorScrollingLayer()) {
+ if (scrollingAncestor->needsCompositedScrolling() && layer->scrollParent())
+ directReasons |= CompositingReasonOverflowScrollingParent;
}
if (layer->needsCompositedScrolling())
« no previous file with comments | « Source/core/rendering/compositing/CompositingInputsUpdater.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698