Issue 402253002: Use lowerCast instead of inlined _movzx, to get legalization, for memset.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 402253002: Use lowerCast instead of inlined _movzx, to get legalization, for memset. (Closed)

Created:
6 years, 5 months ago by jvoung (off chromium)

Modified:
6 years, 5 months ago

Reviewers:
Jim Stichnoth

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Visibility:
Public.

Use lowerCast instead of inlined _movzx, to get legalization, for memset. Otherwise, there can be a movzx reg, 0, which is illegal, when the memset value is constant 0. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3882 R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=957c50d

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -4 lines)			Patch
	M	src/IceTargetLoweringX8632.cpp	View		3 chunks	+6 lines, -4 lines	0 comments	Download
	M	tests_lit/llvm2ice_tests/nacl-other-intrinsics.ll	View		2 chunks	+13 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

jvoung (off chromium)

6 years, 5 months ago (2014-07-21 21:05:35 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r957c50d (presubmit successful).