Issue 40222: Serve developer tools content from chrome-ui://devtools url

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 40222: Serve developer tools content from chrome-ui://devtools url (Closed)

Created:
11 years, 9 months ago by yurys

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse, brettw, pfeldman

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

- Developer tools frontend is served from chrom-ui://devtools/tools.html - Serve Web Inspector JS files from chrom-ui://devtools/ domain in addition to chrom-ui://inspector/. We cannot simply reuse "inspector" domain for now as we need different tab content types for console debugger and new developer tools front-end. When developer tools support all console debugger and web inspector features we will remove "inspector" domain from the source list. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11109

Patch Set 1 #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -3 lines)			Patch
M	chrome/browser/debugger/dev_tools_view.cc	View	2 chunks	+7 lines, -1 line	0 comments	Download
M	chrome/browser/dom_ui/chrome_url_data_manager.cc	View	3 chunks	+11 lines, -2 lines	0 comments	Download
M	chrome/common/url_constants.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/url_constants.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

11 years, 9 months ago (2009-03-06 15:33:46 UTC) #3

LGTM

On 2009/03/06 14:34:11, brettw wrote:
> LGTM

Expand Messages | Collapse Messages