Chromium Code Reviews
Help | Chromium Project | Sign in
(9)

Issue 40222: Serve developer tools content from chrome-ui://devtools url (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 12 months ago by yurys
Modified:
5 years, 9 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

- Developer tools frontend is served from chrom-ui://devtools/tools.html - Serve Web Inspector JS files from chrom-ui://devtools/ domain in addition to chrom-ui://inspector/. We cannot simply reuse "inspector" domain for now as we need different tab content types for console debugger and new developer tools front-end. When developer tools support all console debugger and web inspector features we will remove "inspector" domain from the source list. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11109

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M chrome/browser/debugger/dev_tools_view.cc View 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/chrome_url_data_manager.cc View 3 chunks +11 lines, -2 lines 0 comments Download
M chrome/common/url_constants.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/url_constants.cc View 1 chunk +1 line, -0 lines 0 comments Download
Trybot results:
Commit queue not available (can’t edit this change).

Messages

Total messages: 3 (0 generated)
yurys
7 years, 12 months ago (2009-03-06 14:21:28 UTC) #1
brettw (plz ping after 24h)
LGTM
7 years, 12 months ago (2009-03-06 14:34:11 UTC) #2
Søren Thygesen Gjesse
7 years, 12 months ago (2009-03-06 15:33:46 UTC) #3
LGTM

On 2009/03/06 14:34:11, brettw wrote:
> LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f8e48bd