Issue 402173003: Add bailout checks to Message::Get{Start,End}Column()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 402173003: Add bailout checks to Message::Get{Start,End}Column() (Closed)

Created:
6 years, 5 months ago by sof

Modified:
6 years, 5 months ago

Reviewers:
dcarney, jochen (gone - plz use gerrit)

CC:
v8-dev

Base URL:
git://github.com/v8/v8.git@bleeding_edge

Project:
v8

Visibility:
Public.

Add bailout checks to Message::Get{Start,End}Column() Also add an initial ON_BAILOUT() check to these two 'bailout enabled' accessors. (The need for these was encountered via http://crbug.com/393273) R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22553

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	src/api.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

sof

On 2014/07/21 14:08:46, dcarney wrote: > lgtm Thanks, if a kind committer could propagate this ...

6 years, 5 months ago (2014-07-21 14:38:37 UTC) #3

dcarney

6 years, 5 months ago (2014-07-23 11:21:25 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r22553 (presubmit successful).