Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 402163002: Revert of Remove user-defined move constructor and assignment operator from WTF::String (Closed)

Created:
6 years, 5 months ago by Mikhail
Modified:
6 years, 5 months ago
CC:
blink-reviews, blink-reviews-wtf_chromium.org, abarth-chromium, Erik Corry, tkent, eseidel
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of Remove user-defined move constructor and assignment operator from WTF::String (https://codereview.chromium.org/367343003/) Reason for revert: This can be applied only when user-defined dtor is removed. Original issue's description: > Remove user-defined move constructor and assignment operator from WTF::String > > WTF::String can rely on implicit move constructor and assignment > operator as WTF::RefPtr class has them defined now (r177066). > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178541 TBR=eseidel@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178561

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M Source/wtf/text/WTFString.h View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Mikhail
Created Revert of Remove user-defined move constructor and assignment operator from WTF::String
6 years, 5 months ago (2014-07-21 12:56:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhail.pozdnyakov@intel.com/402163002/1
6 years, 5 months ago (2014-07-21 12:56:50 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-21 12:56:50 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 5 months ago (2014-07-21 12:56:51 UTC) #4
Inactive
On 2014/07/21 12:56:51, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
6 years, 5 months ago (2014-07-21 12:59:45 UTC) #5
Mikhail
The CQ bit was checked by mikhail.pozdnyakov@intel.com
6 years, 5 months ago (2014-07-21 13:02:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhail.pozdnyakov@intel.com/402163002/1
6 years, 5 months ago (2014-07-21 13:03:00 UTC) #7
commit-bot: I haz the power
Change committed as 178561
6 years, 5 months ago (2014-07-21 14:23:52 UTC) #8
Nico
What was the problem with this commit?
6 years, 5 months ago (2014-07-21 14:31:49 UTC) #9
Inactive
On 2014/07/21 14:31:49, Nico (away) wrote: > What was the problem with this commit? I ...
6 years, 5 months ago (2014-07-21 14:34:34 UTC) #10
Mikhail
6 years, 5 months ago (2014-07-21 14:37:23 UTC) #11
Message was sent while issue was closed.
On 2014/07/21 14:31:49, Nico (away) wrote:
> What was the problem with this commit?

The problem is the WTF::String user-defined destructor which prevents from
generating of implicit move/copy ctors.
(Please see the original CL https://codereview.chromium.org/367343003/)

I've created a separate CL to remove the destructor
(https://codereview.chromium.org/402193002/) and if it sticks the reverted patch
can be applied again.

Powered by Google App Engine
This is Rietveld 408576698