Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3167)

Unified Diff: chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc

Issue 402133003: [cros, user_manager] Move default user images constants and helper functions out of src/chrome. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: re-format Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc
diff --git a/chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc b/chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc
index 2ff9d0ab82a1cdb61a02dd40d19ba578a85ada62..75440991520d59fdc24697913a49e52952ec28e3 100644
--- a/chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc
+++ b/chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc
@@ -24,13 +24,13 @@
#include "chrome/browser/browser_process.h"
#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/chromeos/login/helper.h"
-#include "chrome/browser/chromeos/login/users/avatar/default_user_images.h"
#include "chrome/browser/chromeos/login/users/avatar/user_image_sync_observer.h"
#include "chrome/browser/chromeos/login/users/user_manager.h"
#include "chrome/browser/chromeos/profiles/profile_helper.h"
#include "chrome/browser/profiles/profile_downloader.h"
#include "chrome/browser/profiles/profile_manager.h"
#include "chrome/common/chrome_paths.h"
+#include "components/user_manager/user_image/default_user_images.h"
#include "components/user_manager/user_image/user_image.h"
#include "components/user_manager/user_type.h"
#include "content/public/browser/browser_thread.h"
@@ -147,9 +147,9 @@ int ImageIndexToHistogramIndex(int image_index) {
switch (image_index) {
case User::kExternalImageIndex:
// TODO(ivankr): Distinguish this from selected from file.
- return kHistogramImageFromCamera;
+ return user_manager::kHistogramImageFromCamera;
case User::kProfileImageIndex:
- return kHistogramImageFromProfile;
+ return user_manager::kHistogramImageFromProfile;
default:
return image_index;
}
@@ -299,9 +299,10 @@ void UserImageManagerImpl::Job::LoadImage(base::FilePath image_path,
image_url_ = image_url;
image_path_ = image_path;
- if (image_index_ >= 0 && image_index_ < kDefaultImagesCount) {
+ if (image_index_ >= 0 && image_index_ < user_manager::kDefaultImagesCount) {
// Load one of the default images. This happens synchronously.
- user_image_ = user_manager::UserImage(GetDefaultImage(image_index_));
+ user_image_ =
+ user_manager::UserImage(user_manager::GetDefaultImage(image_index_));
UpdateUser();
NotifyJobDone();
} else if (image_index_ == User::kExternalImageIndex ||
@@ -327,10 +328,11 @@ void UserImageManagerImpl::Job::SetToDefaultImage(int default_image_index) {
run_ = true;
DCHECK_LE(0, default_image_index);
- DCHECK_GT(kDefaultImagesCount, default_image_index);
+ DCHECK_GT(user_manager::kDefaultImagesCount, default_image_index);
image_index_ = default_image_index;
- user_image_ = user_manager::UserImage(GetDefaultImage(image_index_));
+ user_image_ =
+ user_manager::UserImage(user_manager::GetDefaultImage(image_index_));
UpdateUser();
UpdateLocalState();
@@ -521,9 +523,10 @@ void UserImageManagerImpl::LoadUserImage() {
int image_index = User::kInvalidImageIndex;
image_properties->GetInteger(kImageIndexNodeName, &image_index);
- if (image_index >= 0 && image_index < kDefaultImagesCount) {
- user->SetImage(user_manager::UserImage(GetDefaultImage(image_index)),
- image_index);
+ if (image_index >= 0 && image_index < user_manager::kDefaultImagesCount) {
+ user->SetImage(
+ user_manager::UserImage(user_manager::GetDefaultImage(image_index)),
+ image_index);
return;
}
@@ -563,7 +566,7 @@ void UserImageManagerImpl::UserLoggedIn(bool user_is_new,
} else {
UMA_HISTOGRAM_ENUMERATION("UserImage.LoggedIn",
ImageIndexToHistogramIndex(user->image_index()),
- kHistogramImagesCount);
+ user_manager::kHistogramImagesCount);
if (!IsUserImageManaged() && user_needs_migration_) {
const base::DictionaryValue* prefs_images_unsafe =
@@ -852,8 +855,9 @@ bool UserImageManagerImpl::IsUserImageManaged() const {
void UserImageManagerImpl::SetInitialUserImage() {
// Choose a random default image.
- SaveUserDefaultImageIndex(base::RandInt(kFirstDefaultImageIndex,
- kDefaultImagesCount - 1));
+ SaveUserDefaultImageIndex(
+ base::RandInt(user_manager::kFirstDefaultImageIndex,
+ user_manager::kDefaultImagesCount - 1));
}
void UserImageManagerImpl::TryToInitDownloadedProfileImage() {
@@ -952,7 +956,7 @@ void UserImageManagerImpl::OnJobDone() {
image_properties->GetInteger(kImageIndexNodeName, &image_index);
UMA_HISTOGRAM_ENUMERATION("UserImage.Migration",
ImageIndexToHistogramIndex(image_index),
- kHistogramImagesCount);
+ user_manager::kHistogramImagesCount);
std::string image_path;
image_properties->GetString(kImagePathNodeName, &image_path);

Powered by Google App Engine
This is Rietveld 408576698