Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1407)

Unified Diff: Source/devtools/front_end/profiler/CPUProfileFlameChart.js

Issue 402113002: Draw marker events on Timeline flame chart (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/profiler/CPUProfileFlameChart.js
diff --git a/Source/devtools/front_end/profiler/CPUProfileFlameChart.js b/Source/devtools/front_end/profiler/CPUProfileFlameChart.js
index 10713d9c4c280cdba823614bacd43cf7669a2f22..d1a82ef73b204c6357e649f883626bde41955468 100644
--- a/Source/devtools/front_end/profiler/CPUProfileFlameChart.js
+++ b/Source/devtools/front_end/profiler/CPUProfileFlameChart.js
@@ -111,6 +111,24 @@ WebInspector.CPUFlameChartDataProvider.prototype = {
},
/**
+ * @param {number} index
+ * @return {string}
+ */
+ markerColor: function(index)
+ {
+ throw new Error("Unreachable.");
+ },
+
+ /**
+ * @param {number} index
+ * @return {string}
+ */
+ markerTitle: function(index)
+ {
+ throw new Error("Unreachable.");
+ },
+
+ /**
* @return {?WebInspector.FlameChart.TimelineData}
*/
_calculateTimelineData: function()
@@ -172,12 +190,7 @@ WebInspector.CPUFlameChartDataProvider.prototype = {
this._maxStackDepth = maxDepth;
- /** @type {!WebInspector.FlameChart.TimelineData} */
- this._timelineData = {
- entryLevels: entryLevels,
- entryTotalTimes: entryTotalTimes,
- entryStartTimes: entryStartTimes,
- };
+ this._timelineData = new WebInspector.FlameChart.TimelineData(entryLevels, entryTotalTimes, entryStartTimes);
/** @type {!Array.<!ProfilerAgent.CPUProfileNode>} */
this._entryNodes = entryNodes;

Powered by Google App Engine
This is Rietveld 408576698