Linux: Fix regression issue 27964: ctrl+tab loses focus from the text box....

chrome/browser/renderer_host/gtk_key_bindings_handler.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_host/gtk_key_bindings_handler.h"
 
 #include <gdk/gdkkeysyms.h>
 
 #include <string>
 
@@ skipping 42 matching lines @@
   // We don't need to show the |handler| object on screen, so set its size to
   // zero.
   gtk_widget_set_size_request(GTK_WIDGET(handler), 0, 0);
 
   // Prevents it from handling any events by itself.
   gtk_widget_set_sensitive(GTK_WIDGET(handler), FALSE);
   gtk_widget_set_events(GTK_WIDGET(handler), 0);
   GTK_WIDGET_UNSET_FLAGS(GTK_WIDGET(handler), GTK_CAN_FOCUS);
 
 #if !GTK_CHECK_VERSION(2, 14, 0)
-  // "move-viewport", "select-all" and "toggle-cursor-visible" have no
-  // corresponding virtual methods. Prior to glib 2.18 (gtk 2.14), there is no
-  // way to override the default class handler of a signal. So we need hook
-  // these signal explicitly.
+  // "move-focus", "move-viewport", "select-all" and "toggle-cursor-visible"
+  // have no corresponding virtual methods. Prior to glib 2.18 (gtk 2.14),
+  // there is no way to override the default class handler of a signal.
+  // So we need hook these signal explicitly.
+  g_signal_connect(handler, "move-focus", G_CALLBACK(MoveFocus), NULL);
   g_signal_connect(handler, "move-viewport", G_CALLBACK(MoveViewport), NULL);
   g_signal_connect(handler, "select-all", G_CALLBACK(SelectAll), NULL);
   g_signal_connect(handler, "toggle-cursor-visible",
                    G_CALLBACK(ToggleCursorVisible), NULL);
 #endif
   return GTK_WIDGET(handler);
 }
 
 void GtkKeyBindingsHandler::EditCommandMatched(
     const std::string& name, const std::string& value) {
   edit_commands_.push_back(EditCommand(name, value));
 }
 
 void GtkKeyBindingsHandler::HandlerInit(Handler *self) {
   self->owner = NULL;
 }
 
 void GtkKeyBindingsHandler::HandlerClassInit(HandlerClass *klass) {
   GtkTextViewClass* text_view_class = GTK_TEXT_VIEW_CLASS(klass);
+  GtkWidgetClass* widget_class = GTK_WIDGET_CLASS(klass);
 
   // Overrides all virtual methods related to editor key bindings.
   text_view_class->backspace = BackSpace;
   text_view_class->copy_clipboard = CopyClipboard;
   text_view_class->cut_clipboard = CutClipboard;
   text_view_class->delete_from_cursor = DeleteFromCursor;
   text_view_class->insert_at_cursor = InsertAtCursor;
   text_view_class->move_cursor = MoveCursor;
   text_view_class->paste_clipboard = PasteClipboard;
   text_view_class->set_anchor = SetAnchor;
   text_view_class->toggle_overwrite = ToggleOverwrite;
+  widget_class->show_help = ShowHelp;
 
 #if GTK_CHECK_VERSION(2, 14, 0)
-  // "move-viewport", "select-all" and "toggle-cursor-visible" have no
-  // corresponding virtual methods. Since glib 2.18 (gtk 2.14),
+  // "move-focus", "move-viewport", "select-all" and "toggle-cursor-visible"
+  // have no corresponding virtual methods. Since glib 2.18 (gtk 2.14),
   // g_signal_override_class_handler() is introduced to override a signal
   // handler.
+  g_signal_override_class_handler("move-focus",
+                                  G_TYPE_FROM_CLASS(klass),
+                                  G_CALLBACK(MoveFocus));
+
   g_signal_override_class_handler("move-viewport",
                                   G_TYPE_FROM_CLASS(klass),
                                   G_CALLBACK(MoveViewport));
 
   g_signal_override_class_handler("select-all",
                                   G_TYPE_FROM_CLASS(klass),
                                   G_CALLBACK(SelectAll));
 
   g_signal_override_class_handler("toggle-cursor-visible",
                                   G_TYPE_FROM_CLASS(klass),
@@ skipping 182 matching lines @@
   // Before gtk 2.14.0, there is no way to override a non-virtual default signal
   // handler, so we need stop the signal emission explicitly to prevent the
   // default handler from being executed.
   g_signal_stop_emission_by_name(text_view, "toggle-cursor-visible");
 #endif
 }
 
 void GtkKeyBindingsHandler::ToggleOverwrite(GtkTextView* text_view) {
   // Not supported by webkit.
 }
+
+gboolean GtkKeyBindingsHandler::ShowHelp(GtkWidget* widget,
+                                         GtkWidgetHelpType arg1) {
+  // Just for disabling the default handler.
+  return FALSE;
+}
+
+void GtkKeyBindingsHandler::MoveFocus(GtkWidget* widget,
+                                      GtkDirectionType arg1) {
+  // Just for disabling the default handler.
+#if !GTK_CHECK_VERSION(2, 14, 0)
+  // Before gtk 2.14.0, there is no way to override a non-virtual default signal
+  // handler, so we need stop the signal emission explicitly to prevent the
+  // default handler from being executed.
+  g_signal_stop_emission_by_name(widget, "move-focus");
+#endif
+}