Ensure that the renderer has focus when ChromeFrame navigates to a URL in IE ...

Ensure that the renderer has focus when ChromeFrame navigates to a URL in IE full tab mode.

This fixes bug http://code.google.com/p/chromium/issues/detail?id=22745

Test=Covered by unit test.
Bug=22745
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32497

[amit, 2009-11-19 03:10:48]

LGTM. Nice new test.

http://codereview.chromium.org/402079/diff/1/3
File chrome_frame/chrome_active_document.cc (right):

http://codereview.chromium.org/402079/diff/1/3#newcode177
Line 177: Base::OnAutomationServerReady();
unless it is dependent on focus, it's probably better to call base
implementation first.

http://codereview.chromium.org/402079/diff/1/5
File chrome_frame/chrome_active_document.h (right):

http://codereview.chromium.org/402079/diff/1/5#newcode215
Line 215: virtual void OnAutomationServerReady();
will a similar issue exist if ActiveX has initial focus? In that case we should
consider doing this in ActivexBase?

http://codereview.chromium.org/402079/diff/1/2
File chrome_frame/chrome_frame_plugin.h (right):

http://codereview.chromium.org/402079/diff/1/2#newcode125
Line 125: GiveFocusToChrome();
nice helper :)

http://codereview.chromium.org/402079/diff/1/4
File chrome_frame/test/chrome_frame_unittests.cc (right):

http://codereview.chromium.org/402079/diff/1/4#newcode101
Line 101: if (url.find(L"files/") != std::wstring::npos)
why this hack is here?

[ananta, 2009-11-19 03:15:07]

http://codereview.chromium.org/402079/diff/1/3
File chrome_frame/chrome_active_document.cc (right):

http://codereview.chromium.org/402079/diff/1/3#newcode177
Line 177: Base::OnAutomationServerReady();
On 2009/11/19 03:10:48, amit wrote:
> unless it is dependent on focus, it's probably better to call base
> implementation first.

Done.

http://codereview.chromium.org/402079/diff/1/5
File chrome_frame/chrome_active_document.h (right):

http://codereview.chromium.org/402079/diff/1/5#newcode215
Line 215: virtual void OnAutomationServerReady();
On 2009/11/19 03:10:48, amit wrote:
> will a similar issue exist if ActiveX has initial focus? In that case we
should
> consider doing this in ActivexBase? 

If the ActiveX has initial focus then we will handle that in WM_SETFOCUS and
ensure that Chrome gets focus.

http://codereview.chromium.org/402079/diff/1/4
File chrome_frame/test/chrome_frame_unittests.cc (right):

http://codereview.chromium.org/402079/diff/1/4#newcode101
Line 101: if (url.find(L"files/") != std::wstring::npos)
On 2009/11/19 03:10:48, amit wrote:
> why this hack is here?
This function assumes that the URL passed in is a relative URL which can be
handled by the HTTP Test server. The new test uses the same function to navigate
IE to cf:about:blank.