Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4848)

Unified Diff: chrome/browser/cocoa/preferences_window_controller_unittest.mm

Issue 402066: Moved a whole pile of unittests over to CocoaTest. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/preferences_window_controller_unittest.mm
===================================================================
--- chrome/browser/cocoa/preferences_window_controller_unittest.mm (revision 32421)
+++ chrome/browser/cocoa/preferences_window_controller_unittest.mm (working copy)
@@ -41,19 +41,19 @@
PrefService* prefs = browser_helper_.profile()->GetPrefs();
prefs->RegisterBooleanPref(prefs::kMetricsReportingEnabled, false);
- pref_controller_.reset([[PreferencesWindowController alloc]
- initWithProfile:browser_helper_.profile()
- initialPage:OPTIONS_PAGE_DEFAULT]);
- EXPECT_TRUE(pref_controller_.get());
+ pref_controller_ = [[PreferencesWindowController alloc]
+ initWithProfile:browser_helper_.profile()
+ initialPage:OPTIONS_PAGE_DEFAULT];
+ EXPECT_TRUE(pref_controller_);
}
virtual void TearDown() {
- pref_controller_.reset(NULL);
+ [pref_controller_ close];
CocoaTest::TearDown();
}
BrowserTestHelper browser_helper_;
- scoped_nsobject<PreferencesWindowController> pref_controller_;
+ PreferencesWindowController* pref_controller_;
};
// Test showing the preferences window and making sure it's visible, then
@@ -64,14 +64,15 @@
scoped_nsobject<PrefsClosedObserver> observer(
[[PrefsClosedObserver alloc] init]);
- [[NSNotificationCenter defaultCenter]
- addObserver:observer.get()
- selector:@selector(prefsWindowClosed:)
- name:kUserDoneEditingPrefsNotification
- object:pref_controller_.get()];
+ NSNotificationCenter* defaultCenter = [NSNotificationCenter defaultCenter];
+ [defaultCenter addObserver:observer.get()
+ selector:@selector(prefsWindowClosed:)
+ name:NSWindowWillCloseNotification
+ object:[pref_controller_ window]];
[[pref_controller_ window] performClose:observer];
EXPECT_TRUE(observer.get()->gotNotification_);
- [[NSNotificationCenter defaultCenter] removeObserver:observer.get()];
+ [defaultCenter removeObserver:observer.get()];
+ pref_controller_ = nil;
}
TEST_F(PrefsControllerTest, ValidateCustomHomePagesTable) {
« no previous file with comments | « chrome/browser/cocoa/preferences_window_controller.mm ('k') | chrome/browser/cocoa/styled_text_field_cell_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698