Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1735)

Unified Diff: chrome/browser/cocoa/about_window_controller_unittest.mm

Issue 402066: Moved a whole pile of unittests over to CocoaTest. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/about_window_controller_unittest.mm
===================================================================
--- chrome/browser/cocoa/about_window_controller_unittest.mm (revision 32421)
+++ chrome/browser/cocoa/about_window_controller_unittest.mm (working copy)
@@ -31,17 +31,21 @@
userInfo:dictionary];
}
-class AboutWindowControllerTest : public PlatformTest {
+class AboutWindowControllerTest : public CocoaTest {
public:
virtual void SetUp() {
- PlatformTest::SetUp();
- about_window_controller_.reset([[AboutWindowController alloc]
- initWithProfile:nil]);
- // make sure the nib is loaded
- [about_window_controller_ window];
+ CocoaTest::SetUp();
+ about_window_controller_ =
+ [[AboutWindowController alloc] initWithProfile:nil];
+ EXPECT_TRUE([about_window_controller_ window]);
}
- scoped_nsobject<AboutWindowController> about_window_controller_;
+ virtual void TearDown() {
+ [about_window_controller_ close];
+ CocoaTest::TearDown();
+ }
+
+ AboutWindowController* about_window_controller_;
};
TEST_F(AboutWindowControllerTest, TestCopyright) {
@@ -82,7 +86,7 @@
ASSERT_TRUE([button isEnabled]);
// Make sure the button is hooked up
- ASSERT_EQ([button target], about_window_controller_.get());
+ ASSERT_EQ([button target], about_window_controller_);
ASSERT_EQ([button action], @selector(updateNow:));
}
« no previous file with comments | « chrome/browser/cocoa/about_window_controller.mm ('k') | chrome/browser/cocoa/autocomplete_text_field_editor_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698