Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Unified Diff: chrome/browser/cocoa/about_ipc_controller_unittest.mm

Issue 402066: Moved a whole pile of unittests over to CocoaTest. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/app_controller_mac.mm ('k') | chrome/browser/cocoa/about_window_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/about_ipc_controller_unittest.mm
===================================================================
--- chrome/browser/cocoa/about_ipc_controller_unittest.mm (revision 32421)
+++ chrome/browser/cocoa/about_ipc_controller_unittest.mm (working copy)
@@ -15,21 +15,19 @@
namespace {
-class AboutIPCControllerTest : public PlatformTest {
- CocoaTestHelper cocoa_helper_; // Inits Cocoa, creates window, etc...
+class AboutIPCControllerTest : public CocoaTest {
};
TEST_F(AboutIPCControllerTest, TestFilter) {
- scoped_nsobject<AboutIPCController> controller(
- [[AboutIPCController alloc] init]);
- [controller window]; // force nib load.
+ AboutIPCController* controller = [[AboutIPCController alloc] init];
+ EXPECT_TRUE([controller window]); // force nib load.
IPC::LogData data;
// Make sure generic names do NOT get filtered.
std::wstring names[] = { L"PluginProcessingIsMyLife",
L"ViewMsgFoo",
L"NPObjectHell" };
- for (unsigned int i = 0; i < arraysize(names); i++) {
+ for (size_t i = 0; i < arraysize(names); i++) {
data.message_name = names[i];
scoped_nsobject<CocoaLogData> cdata([[CocoaLogData alloc]
initWithLogData:data]);
@@ -44,6 +42,7 @@
EXPECT_TRUE([controller filterOut:cdata.get()]);
[controller setDisplayViewMessages:YES];
EXPECT_FALSE([controller filterOut:cdata.get()]);
+ [controller close];
}
} // namespace
« no previous file with comments | « chrome/browser/app_controller_mac.mm ('k') | chrome/browser/cocoa/about_window_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698