Moved a whole pile of unittests over to CocoaTest.

chrome/browser/cocoa/autocomplete_text_field_unittest.mm

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Cocoa/Cocoa.h>
 
 #import "base/cocoa_protocols_mac.h"
 #include "base/scoped_nsobject.h"
 #import "chrome/browser/cocoa/autocomplete_text_field.h"
 #import "chrome/browser/cocoa/autocomplete_text_field_cell.h"
@@ skipping 50 matching lines @@
                             pressure:0.0];
 }
 NSEvent* Event(NSView* view, const NSPoint point, const NSEventType type) {
   return Event(view, point, type, 1);
 }
 
 // Width of the field so that we don't have to ask |field_| for it all
 // the time.
 static const CGFloat kWidth(300.0);
 
-class AutocompleteTextFieldTest : public PlatformTest {
+class AutocompleteTextFieldTest : public CocoaTest {
  public:
   AutocompleteTextFieldTest() {
     // Make sure this is wide enough to play games with the cell
     // decorations.
     NSRect frame = NSMakeRect(0, 0, kWidth, 30);
-    field_.reset([[AutocompleteTextField alloc] initWithFrame:frame]);
+    scoped_nsobject<AutocompleteTextField> field(
+        [[AutocompleteTextField alloc] initWithFrame:frame]);
+    field_ = field.get();
     [field_ setStringValue:@"Test test"];
     [field_ setObserver:&field_observer_];
-    [cocoa_helper_.contentView() addSubview:field_.get()];
+    [[test_window() contentView] addSubview:field_];
 
     window_delegate_.reset(
         [[AutocompleteTextFieldWindowTestDelegate alloc] init]);
-    [cocoa_helper_.window() setDelegate:window_delegate_.get()];
-  }
-
-  // The removeFromSuperview call is needed to prevent crashes in
-  // later tests.
-  // TODO(shess): -removeromSuperview should not be necessary.  Fix
-  // it.  Also in autocomplete_text_field_editor_unittest.mm.
-  ~AutocompleteTextFieldTest() {
-    [cocoa_helper_.window() setDelegate:nil];
-    [field_ removeFromSuperview];
+    [test_window() setDelegate:window_delegate_.get()];
   }
 
   NSEvent* KeyDownEventWithFlags(NSUInteger flags) {
     return [NSEvent keyEventWithType:NSKeyDown
                             location:NSZeroPoint
                        modifierFlags:flags
                            timestamp:0.0
-                        windowNumber:[cocoa_helper_.window() windowNumber]
+                        windowNumber:[test_window() windowNumber]
                              context:nil
                           characters:@"a"
          charactersIgnoringModifiers:@"a"
                            isARepeat:NO
                              keyCode:'a'];
   }
 
   // Helper to return the field-editor frame being used w/in |field_|.
   NSRect EditorFrame() {
-    EXPECT_TRUE([field_.get() currentEditor]);
-    EXPECT_EQ([[field_.get() subviews] count], 1U);
-    if ([[field_.get() subviews] count] > 0) {
-      return [[[field_.get() subviews] objectAtIndex:0] frame];
+    EXPECT_TRUE([field_ currentEditor]);
+    EXPECT_EQ([[field_ subviews] count], 1U);
+    if ([[field_ subviews] count] > 0) {
+      return [[[field_ subviews] objectAtIndex:0] frame];
     } else {
       // Return something which won't work so the caller can soldier
       // on.
       return NSZeroRect;
     }
   }
 
-  CocoaTestHelper cocoa_helper_;  // Inits Cocoa, creates window, etc...
-  scoped_nsobject<AutocompleteTextField> field_;
+  AutocompleteTextField* field_;
   MockAutocompleteTextFieldObserver field_observer_;
   scoped_nsobject<AutocompleteTextFieldWindowTestDelegate> window_delegate_;
 };
 
+TEST_VIEW(AutocompleteTextFieldTest, field_);
+
 // Test that we have the right cell class.
 TEST_F(AutocompleteTextFieldTest, CellClass) {
   EXPECT_TRUE([[field_ cell] isKindOfClass:[AutocompleteTextFieldCell class]]);
 }
 
-// Test adding/removing from the view hierarchy, mostly to ensure nothing
-// leaks or crashes.
-TEST_F(AutocompleteTextFieldTest, AddRemove) {
-  EXPECT_EQ(cocoa_helper_.contentView(), [field_ superview]);
-  [field_.get() removeFromSuperview];
-  EXPECT_FALSE([field_ superview]);
-}
-
 // Test that we get the same cell from -cell and
 // -autocompleteTextFieldCell.
 TEST_F(AutocompleteTextFieldTest, Cell) {
   AutocompleteTextFieldCell* cell = [field_ autocompleteTextFieldCell];
   EXPECT_EQ(cell, [field_ cell]);
   EXPECT_TRUE(cell != nil);
 }
 
 // Test that becoming first responder sets things up correctly.
 TEST_F(AutocompleteTextFieldTest, FirstResponder) {
   EXPECT_EQ(nil, [field_ currentEditor]);
   EXPECT_EQ([[field_ subviews] count], 0U);
-  cocoa_helper_.makeFirstResponder(field_);
+  [test_window() makePretendKeyWindowAndSetFirstResponder:field_];
   EXPECT_FALSE(nil == [field_ currentEditor]);
   EXPECT_EQ([[field_ subviews] count], 1U);
-  EXPECT_TRUE([[field_ currentEditor] isDescendantOf:field_.get()]);
+  EXPECT_TRUE([[field_ currentEditor] isDescendantOf:field_]);
 
   // Check that the window delegate is providing the right editor.
   Class c = [AutocompleteTextFieldEditor class];
   EXPECT_TRUE([[field_ currentEditor] isKindOfClass:c]);
 }
 
 TEST_F(AutocompleteTextFieldTest, AvailableDecorationWidth) {
   // A fudge factor to account for how much space the border takes up.
   // The test shouldn't be too dependent on the field's internals, but
   // it also shouldn't let deranged cases fall through the cracks
@@ skipping 25 matching lines @@
   [field_ setStringValue:string];
   availableWidth = [field_ availableDecorationWidth];
   EXPECT_LT(availableWidth, 0.0);
 }
 
 // Test drawing, mostly to ensure nothing leaks or crashes.
 TEST_F(AutocompleteTextFieldTest, Display) {
   [field_ display];
 
   // Test focussed drawing.
-  cocoa_helper_.makeFirstResponder(field_);
+  [test_window() makePretendKeyWindowAndSetFirstResponder:field_];
   [field_ display];
-  cocoa_helper_.clearFirstResponder();
+  [test_window() clearPretendKeyWindowAndFirstResponder];
 
   // Test display of various cell configurations.
   AutocompleteTextFieldCell* cell = [field_ autocompleteTextFieldCell];
 
   [cell setSearchHintString:@"Type to search" availableWidth:kWidth];
   [field_ display];
 
   NSImage* image = [NSImage imageNamed:@"NSApplicationIcon"];
   [cell setKeywordHintPrefix:@"prefix" image:image suffix:@"suffix"
               availableWidth:kWidth];
@@ skipping 17 matching lines @@
 
   // Test with Control key down.
   EXPECT_CALL(field_observer_, OnControlKeyChanged(true));
   [field_ flagsChanged:KeyDownEventWithFlags(NSControlKeyMask)];
 }
 
 // This test is here rather than in the editor's tests because the
 // field catches -flagsChanged: because it's on the responder chain,
 // the field editor doesn't implement it.
 TEST_F(AutocompleteTextFieldTest, FieldEditorFlagsChanged) {
-  cocoa_helper_.makeFirstResponder(field_);
+  [test_window() makePretendKeyWindowAndSetFirstResponder:field_];
   NSResponder* firstResponder = [[field_ window] firstResponder];
   EXPECT_EQ(firstResponder, [field_ currentEditor]);
 
   InSequence dummy;  // Call mock in exactly the order specified.
 
   // Test without Control key down, but some other modifier down.
   EXPECT_CALL(field_observer_, OnControlKeyChanged(false));
   [firstResponder flagsChanged:KeyDownEventWithFlags(NSShiftKeyMask)];
 
   // Test with Control key down.
@@ skipping 10 matching lines @@
 }
 
 // Test that the field editor gets the same bounds when focus is
 // delivered by the standard focusing machinery, or by
 // -resetFieldEditorFrameIfNeeded.
 TEST_F(AutocompleteTextFieldTest, ResetFieldEditorBase) {
   AutocompleteTextFieldCell* cell = [field_ autocompleteTextFieldCell];
 
   // Capture the editor frame resulting from the standard focus
   // machinery.
-  cocoa_helper_.makeFirstResponder(field_);
+  [test_window() makePretendKeyWindowAndSetFirstResponder:field_];
   const NSRect baseEditorFrame(EditorFrame());
 
   // Setting a hint should result in a strictly smaller editor frame.
   EXPECT_FALSE([cell hintString]);
   [cell setSearchHintString:@"search hint" availableWidth:kWidth];
   EXPECT_TRUE([cell hintString]);
   [field_ resetFieldEditorFrameIfNeeded];
   EXPECT_FALSE(NSEqualRects(baseEditorFrame, EditorFrame()));
   EXPECT_TRUE(NSContainsRect(baseEditorFrame, EditorFrame()));
 
@@ skipping 10 matching lines @@
 // -resetFieldEditorFrameIfNeeded.
 TEST_F(AutocompleteTextFieldTest, ResetFieldEditorSearchHint) {
   AutocompleteTextFieldCell* cell = [field_ autocompleteTextFieldCell];
 
   const NSString* kHintString(@"Type to search");
 
   // Capture the editor frame resulting from the standard focus
   // machinery.
   [cell setSearchHintString:kHintString availableWidth:kWidth];
   EXPECT_TRUE([cell hintString]);
-  cocoa_helper_.makeFirstResponder(field_);
+  [test_window() makePretendKeyWindowAndSetFirstResponder:field_];
   const NSRect baseEditorFrame(EditorFrame());
 
   // Clearing the hint should result in a strictly larger editor
   // frame.
   [cell clearKeywordAndHint];
   EXPECT_FALSE([cell hintString]);
   [field_ resetFieldEditorFrameIfNeeded];
   EXPECT_FALSE(NSEqualRects(baseEditorFrame, EditorFrame()));
   EXPECT_TRUE(NSContainsRect(EditorFrame(), baseEditorFrame));
 
@@ skipping 14 matching lines @@
 
   const NSString* kFullString(@"Search Engine:");
   const NSString* kPartialString(@"Search Eng:");
 
   // Capture the editor frame resulting from the standard focus
   // machinery.
   [cell setKeywordString:kFullString
            partialString:kPartialString
           availableWidth:kWidth];
   EXPECT_TRUE([cell keywordString]);
-  cocoa_helper_.makeFirstResponder(field_);
+  [test_window() makePretendKeyWindowAndSetFirstResponder:field_];
   const NSRect baseEditorFrame(EditorFrame());
 
   // Clearing the hint should result in a strictly larger editor
   // frame.
   [cell clearKeywordAndHint];
   EXPECT_FALSE([cell keywordString]);
   [field_ resetFieldEditorFrameIfNeeded];
   EXPECT_FALSE(NSEqualRects(baseEditorFrame, EditorFrame()));
   EXPECT_TRUE(NSContainsRect(EditorFrame(), baseEditorFrame));
 
@@ skipping 14 matching lines @@
   // First, test that -makeFirstResponder: sends
   // -controlTextDidBeginEditing: and -control:textShouldEndEditing at
   // the expected times.
   {
     id mockDelegate =
         [OCMockObject mockForProtocol:@protocol(MockTextEditingDelegate)];
 
     [field_ setDelegate:mockDelegate];
 
     // Becoming first responder doesn't begin editing.
-    cocoa_helper_.makeFirstResponder(field_);
+    [test_window() makePretendKeyWindowAndSetFirstResponder:field_];
     NSTextView* editor = static_cast<NSTextView*>([field_ currentEditor]);
     EXPECT_TRUE(nil != editor);
     [mockDelegate verify];
 
     // This should begin editing.
     [[mockDelegate expect] controlTextDidBeginEditing:OCMOCK_ANY];
     [editor shouldChangeTextInRange:NSMakeRange(0, 0) replacementString:@""];
     [mockDelegate verify];
 
     // Changing first responder ends editing.
     BOOL yes = YES;
     [[[mockDelegate expect] andReturnValue:OCMOCK_VALUE(yes)]
       control:OCMOCK_ANY textShouldEndEditing:OCMOCK_ANY];
-    cocoa_helper_.makeFirstResponder(field_);
+    [test_window() makePretendKeyWindowAndSetFirstResponder:field_];
     [mockDelegate verify];
 
     [field_ setDelegate:nil];
   }
 
   // Test that -resetFieldEditorFrameIfNeeded manages to rearrange the
   // editor without ending editing.
   {
     id mockDelegate =
         [OCMockObject mockForProtocol:@protocol(MockTextEditingDelegate)];
@@ skipping 19 matching lines @@
 // Clicking in the search hint should put the caret in the rightmost
 // position.
 TEST_F(AutocompleteTextFieldTest, ClickSearchHintPutsCaretRightmost) {
   // Set the decoration before becoming responder.
   EXPECT_FALSE([field_ currentEditor]);
   AutocompleteTextFieldCell* cell = [field_ autocompleteTextFieldCell];
   [cell setSearchHintString:@"Type to search" availableWidth:kWidth];
 
   // Can't rely on the window machinery to make us first responder,
   // here.
-  cocoa_helper_.makeFirstResponder(field_);
+  [test_window() makePretendKeyWindowAndSetFirstResponder:field_];
   EXPECT_TRUE([field_ currentEditor]);
 
   const NSPoint point(NSMakePoint(300.0 - 20.0, 5.0));
   NSEvent* downEvent(Event(field_, point, NSLeftMouseDown));
   NSEvent* upEvent(Event(field_, point, NSLeftMouseUp));
   [NSApp postEvent:upEvent atStart:YES];
   [field_ mouseDown:downEvent];
   const NSRange selectedRange([[field_ currentEditor] selectedRange]);
   EXPECT_EQ(selectedRange.location, [[field_ stringValue] length]);
   EXPECT_EQ(selectedRange.length, 0U);
 }
 
 // Clicking in the keyword-search should put the caret in the
 // leftmost position.
 TEST_F(AutocompleteTextFieldTest, ClickKeywordPutsCaretLeftmost) {
   // Set the decoration before becoming responder.
   EXPECT_FALSE([field_ currentEditor]);
   AutocompleteTextFieldCell* cell = [field_ autocompleteTextFieldCell];
   [cell setKeywordString:@"Search Engine:"
            partialString:@"Search:"
           availableWidth:kWidth];
 
   // Can't rely on the window machinery to make us first responder,
   // here.
-  cocoa_helper_.makeFirstResponder(field_);
+  [test_window() makePretendKeyWindowAndSetFirstResponder:field_];
   EXPECT_TRUE([field_ currentEditor]);
 
   const NSPoint point(NSMakePoint(20.0, 5.0));
   NSEvent* downEvent(Event(field_, point, NSLeftMouseDown));
   NSEvent* upEvent(Event(field_, point, NSLeftMouseUp));
   [NSApp postEvent:upEvent atStart:YES];
   [field_ mouseDown:downEvent];
   const NSRange selectedRange([[field_ currentEditor] selectedRange]);
   EXPECT_EQ(selectedRange.location, 0U);
   EXPECT_EQ(selectedRange.length, 0U);
 }
 
 // Clicks not in the text area or the cell's decorations fall through
 // to the editor.
 TEST_F(AutocompleteTextFieldTest, ClickBorderSelectsAll) {
   // Can't rely on the window machinery to make us first responder,
   // here.
-  cocoa_helper_.makeFirstResponder(field_);
+  [test_window() makePretendKeyWindowAndSetFirstResponder:field_];
   EXPECT_TRUE([field_ currentEditor]);
 
   const NSPoint point(NSMakePoint(20.0, 1.0));
   NSEvent* downEvent(Event(field_, point, NSLeftMouseDown));
   NSEvent* upEvent(Event(field_, point, NSLeftMouseUp));
   [NSApp postEvent:upEvent atStart:YES];
   [field_ mouseDown:downEvent];
 
   // Clicking in the narrow border area around a Cocoa NSTextField
   // does a select-all.  Regardless of whether this is a good call, it
@@ skipping 132 matching lines @@
                                       attributes:attributes]);
 
   // Check that what we get back looks like what we put in.
   EXPECT_FALSE([[field_ stringValue] isEqualToString:kString]);
   [field_ setAttributedStringValue:attributedString];
   EXPECT_TRUE([[field_ attributedStringValue]
                 isEqualToAttributedString:attributedString]);
   EXPECT_TRUE([[field_ stringValue] isEqualToString:kString]);
 
   // Try that again with focus.
-  cocoa_helper_.makeFirstResponder(field_);
+  [test_window() makePretendKeyWindowAndSetFirstResponder:field_];
+
   EXPECT_TRUE([field_ currentEditor]);
 
   // Check that what we get back looks like what we put in.
   [field_ setStringValue:@""];
   EXPECT_FALSE([[field_ stringValue] isEqualToString:kString]);
   [field_ setAttributedStringValue:attributedString];
   EXPECT_TRUE([[field_ attributedStringValue]
                 isEqualToAttributedString:attributedString]);
   EXPECT_TRUE([[field_ stringValue] isEqualToString:kString]);
 }
 
 // -setAttributedStringValue: shouldn't reset the undo state if things
 // are being editted.
 TEST_F(AutocompleteTextFieldTest, SetAttributedStringUndo) {
   NSColor* redColor = [NSColor redColor];
   NSDictionary* attributes =
       [NSDictionary dictionaryWithObject:redColor
                                   forKey:NSForegroundColorAttributeName];
   static const NSString* kString = @"This is a test";
   scoped_nsobject<NSAttributedString> attributedString(
       [[NSAttributedString alloc] initWithString:kString
                                       attributes:attributes]);
-
-  cocoa_helper_.makeFirstResponder(field_);
+  [test_window() makePretendKeyWindowAndSetFirstResponder:field_];
   EXPECT_TRUE([field_ currentEditor]);
   NSTextView* editor = static_cast<NSTextView*>([field_ currentEditor]);
   NSUndoManager* undoManager = [editor undoManager];
   EXPECT_TRUE(undoManager);
 
   // Nothing to undo, yet.
   EXPECT_FALSE([undoManager canUndo]);
 
   // Starting an editing action creates an undoable item.
   [editor shouldChangeTextInRange:NSMakeRange(0, 0) replacementString:@""];
@@ skipping 12 matching lines @@
   EXPECT_TRUE([undoManager canUndo]);
   [field_ setAttributedStringValue:attributedString];
   EXPECT_TRUE([undoManager canUndo]);
 
   // Verify that calling -clearUndoChain clears the undo chain.
   [field_ clearUndoChain];
   EXPECT_FALSE([undoManager canUndo]);
 }
 
 TEST_F(AutocompleteTextFieldTest, EditorGetsCorrectUndoManager) {
-  cocoa_helper_.makeFirstResponder(field_);
+  [test_window() makePretendKeyWindowAndSetFirstResponder:field_];
 
   NSTextView* editor = static_cast<NSTextView*>([field_ currentEditor]);
   EXPECT_TRUE(editor);
   EXPECT_EQ([field_ undoManagerForTextView:editor], [editor undoManager]);
 }
 }  // namespace