Issue 402065: Made HtmlDialogWindowController on OS X use its own browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 402065: Made HtmlDialogWindowController on OS X use its own browser. (Closed)

Created:
11 years, 1 month ago by akalin

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Made HtmlDialogWindowController on OS X use its own browser object. Fixed some style violations. Made HtmlDialogWindowDelegateBridge stop doing anything after it receives a close notification. This fixes the crash described in issue 28039. BUG=28039 TEST=trybots,manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32445

Patch Set 1 : Initial patch. #

Total comments: 1

Patch Set 2 : synced to head #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+86 lines, -77 lines)			Patch
M	chrome/browser/cocoa/browser_window_cocoa.mm	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/cocoa/html_dialog_window_controller.h	View		4 chunks	+19 lines, -13 lines	0 comments	Download
M	chrome/browser/cocoa/html_dialog_window_controller.mm	View		8 chunks	+62 lines, -59 lines	0 comments	Download
M	chrome/browser/cocoa/html_dialog_window_controller_unittest.mm	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

pink (ping after 24hrs)

LGTM http://codereview.chromium.org/402065/diff/4001/4003 File chrome/browser/cocoa/html_dialog_window_controller.h (right): http://codereview.chromium.org/402065/diff/4001/4003#newcode25 Line 25: // TODO(akalin): This doesn't need to be ...

11 years, 1 month ago (2009-11-18 23:36:52 UTC) #2

akalin

11 years, 1 month ago (2009-11-18 23:46:31 UTC) #3

On 2009/11/18 23:36:52, pink wrote:
> Line 25: // TODO(akalin): This doesn't need to be in the .h file; move it to
the
> why don't you do this now while you're editing these files?

I didn't want to clutter up the diffs.  Don't worry, I'll be doing this
immediately after I check this in. :)

Expand Messages | Collapse Messages