Mojo: Make Connector::Accept() MOJO_CHECK-fail if it sees MOJO_RESULT_BUSY.

Mojo: Make Connector::Accept() MOJO_CHECK-fail if it sees MOJO_RESULT_BUSY.

Seeing this almost certainly indicates a bug in the "user's" code.
Arguably, this should be a MOJO_DCHECK instead, but I'm keeping it as a
MOJO_CHECK since it'll make tests crash-fail on bots instead of hanging
(and then timing out).

(We'll see this failure due to the bugs listed below.)

R=yzshen@chromium.org
BUG=394884, 394886
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284289

[yzshen1, 2014-07-18 22:08:09]

lgtm

https://codereview.chromium.org/401963002/diff/1/mojo/public/cpp/bindings/lib...
File mojo/public/cpp/bindings/lib/connector.cc (right):

https://codereview.chromium.org/401963002/diff/1/mojo/public/cpp/bindings/lib...
mojo/public/cpp/bindings/lib/connector.cc:109: MOJO_CHECK(false) << "Not
reached: race condition or other bug";
nit: other bug*s*. :)

[viettrungluu, 2014-07-18 23:02:20]

On 2014/07/18 22:08:09, yzshen1 wrote:
> lgtm
> 
>
https://codereview.chromium.org/401963002/diff/1/mojo/public/cpp/bindings/lib...
> File mojo/public/cpp/bindings/lib/connector.cc (right):
> 
>
https://codereview.chromium.org/401963002/diff/1/mojo/public/cpp/bindings/lib...
> mojo/public/cpp/bindings/lib/connector.cc:109: MOJO_CHECK(false) << "Not
> reached: race condition or other bug";
> nit: other bug*s*. :)

I'm really saying that that when this check fails, there's either a race
condition or some other bug (singular). Maybe I'll clarify the comment....

[viettrungluu, 2014-07-18 23:13:38]

The CQ bit was checked by viettrungluu@chromium.org

[commit-bot: I haz the power, 2014-07-18 23:15:37]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/401963002/20001

[yzshen1, 2014-07-18 23:19:32]

On 2014/07/18 23:02:20, viettrungluu wrote:
> On 2014/07/18 22:08:09, yzshen1 wrote:
> > lgtm
> > 
> >
>
https://codereview.chromium.org/401963002/diff/1/mojo/public/cpp/bindings/lib...
> > File mojo/public/cpp/bindings/lib/connector.cc (right):
> > 
> >
>
https://codereview.chromium.org/401963002/diff/1/mojo/public/cpp/bindings/lib...
> > mojo/public/cpp/bindings/lib/connector.cc:109: MOJO_CHECK(false) << "Not
> > reached: race condition or other bug";
> > nit: other bug*s*. :)
> 
> I'm really saying that that when this check fails, there's either a race
> condition or some other bug (singular). Maybe I'll clarify the comment....

Ah, I see! :)

[commit-bot: I haz the power, 2014-07-19 02:35:59]

Change committed as 284289