Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1361)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 401953002: Remove some deprecated methods from the chrome.bluetoothPrivate API header. (Closed)

Created:
6 years, 5 months ago by Ilya Sherman
Modified:
6 years, 5 months ago
Reviewers:
keybuk
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, asvitkine+watch_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove some deprecated methods from the chrome.bluetoothPrivate API header. BUG=none TEST=none R=keybuk@chromium.org TBR=keybuk@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285036

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -32 lines) Patch
M chrome/browser/extensions/api/bluetooth/bluetooth_private_api.h View 1 chunk +0 lines, -28 lines 0 comments Download
M extensions/browser/extension_function_histogram_value.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Ilya Sherman
TBR=keybuk, as this is a subset of what you previously LG'ed in [ https://codereview.chromium.org/400843002/ ].
6 years, 5 months ago (2014-07-18 21:37:35 UTC) #1
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 5 months ago (2014-07-18 21:37:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/401953002/1
6 years, 5 months ago (2014-07-18 21:39:52 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-19 00:46:30 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-19 00:50:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/81071)
6 years, 5 months ago (2014-07-19 00:50:23 UTC) #6
keybuk
still lgtm
6 years, 5 months ago (2014-07-22 17:53:13 UTC) #7
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 5 months ago (2014-07-22 23:30:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/401953002/20001
6 years, 5 months ago (2014-07-22 23:34:36 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-23 03:19:12 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-23 03:22:54 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/81671)
6 years, 5 months ago (2014-07-23 03:22:55 UTC) #12
Ilya Sherman
6 years, 5 months ago (2014-07-23 20:45:05 UTC) #13
Message was sent while issue was closed. 
Committed patchset #2 manually as r285036 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698