Move views event targeting into ViewTargeterDelegate::TargetForRect()

Move views event targeting into ViewTargeterDelegate::TargetForRect()

Move the default event-targeting implementation for views from
View::GetEventHandlerForRect() into the new method
ViewTargeterDelegate::TargetForRect() and make the method
View::GetEventHandlerForRect() call into its effective ViewTargeter
instead. The "effective" targeter for a View is the
ViewTargeter installed on that View if one exists, otherwise
it is the ViewTargeter installed on its root view.

Once this change has landed, the overrides of
View::GetEventHandlerForRect() can be removed and their
implementations moved into overrides of
ViewTargeterDelegate::TargetForRect().
View::GetEventHandlerForRect() can then be made
non-virtual.

BUG=391845
TEST=existing coverage in ViewTest.GetEventHandlerForRect

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284342

[tdanderson, 2014-07-18 21:26:05]

Sadrul, can you please take a look? (This is the first of two pieces of
https://codereview.chromium.org/381323002/).

https://codereview.chromium.org/401933002/diff/1/ui/views/view_targeter_deleg...
File ui/views/view_targeter_delegate.cc (right):

https://codereview.chromium.org/401933002/diff/1/ui/views/view_targeter_deleg...
ui/views/view_targeter_delegate.cc:30: View*
ViewTargeterDelegate::TargetForRect(View* root, const gfx::Rect& rect) {
Note this is the same as View::GetEventHandlerForRect() except that implicit
|this| is replaced with |root|.

[sadrul, 2014-07-18 22:17:34]

LGTM

https://codereview.chromium.org/401933002/diff/1/ui/events/event_targeter.h
File ui/events/event_targeter.h (right):

https://codereview.chromium.org/401933002/diff/1/ui/events/event_targeter.h#n...
ui/events/event_targeter.h:20: //                          and
FindNextBestTarget().
This is unrelated to the rest of the CL. Remove (you can file a bug to track
this instead).

https://codereview.chromium.org/401933002/diff/1/ui/views/view_targeter.cc
File ui/views/view_targeter.cc (right):

https://codereview.chromium.org/401933002/diff/1/ui/views/view_targeter.cc#ne...
ui/views/view_targeter.cc:15: : delegate_(delegate) {
Add DCHECK(delegate_) here, and remove the dchecks in lines 22/27

[tdanderson, 2014-07-19 17:32:54]

https://codereview.chromium.org/401933002/diff/1/ui/events/event_targeter.h
File ui/events/event_targeter.h (right):

https://codereview.chromium.org/401933002/diff/1/ui/events/event_targeter.h#n...
ui/events/event_targeter.h:20: //                          and
FindNextBestTarget().
On 2014/07/18 22:17:33, sadrul wrote:
> This is unrelated to the rest of the CL. Remove (you can file a bug to track
> this instead).

Removed, and I will file a separate bug for this.

https://codereview.chromium.org/401933002/diff/1/ui/views/view_targeter.cc
File ui/views/view_targeter.cc (right):

https://codereview.chromium.org/401933002/diff/1/ui/views/view_targeter.cc#ne...
ui/views/view_targeter.cc:15: : delegate_(delegate) {
On 2014/07/18 22:17:33, sadrul wrote:
> Add DCHECK(delegate_) here, and remove the dchecks in lines 22/27

Done.

[tdanderson, 2014-07-19 17:32:59]

The CQ bit was checked by tdanderson@chromium.org

[commit-bot: I haz the power, 2014-07-19 17:33:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tdanderson@chromium.org/401933002/20001

[commit-bot: I haz the power, 2014-07-19 19:12:39]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)

[commit-bot: I haz the power, 2014-07-19 20:03:48]

Change committed as 284342